Re: [Mesa-dev] [RFC PATCH 0/4] proposed scan-build cleanups

2017-04-22 Thread Giuseppe Bilotta
Hello, On Sat, Apr 22, 2017 at 11:46 AM, Nicolai Hähnle wrote: > Definitely split the changes up along a combination of where they are in the > source and what types of errors they are. I'd say the split you've chosen > looks reasonable to me. Excellent, thanks. >> 1. the addition of a check to

Re: [Mesa-dev] [RFC PATCH 0/4] proposed scan-build cleanups

2017-04-22 Thread Nicolai Hähnle
On 22.04.2017 09:52, Giuseppe Bilotta wrote: Just for kicks, I tried building mesa with Clang 4.0 scan-build, to see if there were any ‘easy picks’ up for fixing. The build produces lots of warnings, so going through each of them will require time and care, but at least some of them seem relative

[Mesa-dev] [RFC PATCH 0/4] proposed scan-build cleanups

2017-04-22 Thread Giuseppe Bilotta
Just for kicks, I tried building mesa with Clang 4.0 scan-build, to see if there were any ‘easy picks’ up for fixing. The build produces lots of warnings, so going through each of them will require time and care, but at least some of them seem relatively obvious. I'm not sure what the recommended