Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-23 Thread Emil Velikov
On 22 October 2015 at 23:22, Nanley Chery wrote: > On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov > wrote: >> >> That aside, I'm in favour of keeping the comments as is. The editing >> comment does not apply imho. >> > > Since, there isn't a unanimous opinion on this, I'll leave the FIXME > to sa

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-22 Thread Marek Olšák
On Fri, Oct 23, 2015 at 12:22 AM, Nanley Chery wrote: > > > On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov > wrote: >> >> On 20 October 2015 at 16:43, Nanley Chery wrote: >> > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: >> >> >> >> Also, the FIXME comment should be on its own line. >> >>

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-22 Thread Nanley Chery
On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov wrote: > On 20 October 2015 at 16:43, Nanley Chery wrote: > > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: > >> > >> Also, the FIXME comment should be on its own line. > >> > > > > I moved it aside to make editing the table easier. However, s

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-22 Thread Emil Velikov
On 20 October 2015 at 16:43, Nanley Chery wrote: > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: >> >> Also, the FIXME comment should be on its own line. >> > > I moved it aside to make editing the table easier. However, since the > formatting of the > table is unlikely to change much after

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote: > Also, the FIXME comment should be on its own line. > > I moved it aside to make editing the table easier. However, since the formatting of the table is unlikely to change much after this series, I agree that I should move it back to its origin

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-20 Thread Nanley Chery
On Tue, Oct 20, 2015 at 8:14 AM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund > wrote: > > On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery > wrote: > >> From: Nanley Chery > >> > >> - { "GL_SUN_multi_draw_arrays", o(dummy_true), >

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-20 Thread Marek Olšák
Also, the FIXME comment should be on its own line. Marek On Tue, Oct 20, 2015 at 5:14 PM, Marek Olšák wrote: > On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund wrote: >> On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: >>> From: Nanley Chery >>> >>> - { "GL_SUN_multi_draw_arrays",

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-20 Thread Marek Olšák
On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund wrote: > On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: >> From: Nanley Chery >> >> - { "GL_SUN_multi_draw_arrays", o(dummy_true), >>GLL,1999 }, >> +#define EXT(name_str, driver_

Re: [Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-20 Thread Erik Faye-Lund
On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery wrote: > From: Nanley Chery > > - { "GL_SUN_multi_draw_arrays", o(dummy_true), > GLL,1999 }, > +#define EXT(name_str, driver_cap, api_flags, ) \ > +{ .name = "GL_" #name_str, .

[Mesa-dev] [RFC 03/21] mesa/extensions: Wrap array entries in macros

2015-10-19 Thread Nanley Chery
From: Nanley Chery Now that we're using macros, remove the redundant text from each entry. Remove comments between the entries to make editing easier and separate the sections with blank lines. Structure the EXT macros in a way that helps reviewers verify that no meaning has been altered. Signe