Re: [Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-29 Thread Eric Anholt
Kenneth Graunke writes: > On Wednesday, June 03, 2015 09:21:11 PM Topi Pohjolainen wrote: >> Shader programs are cached per stage (FS, VS, GS) using the >> corresponding shader source identifier and compile time choices >> as key. However, one not only stores the program binary but >> a pair cons

Re: [Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-25 Thread Kenneth Graunke
On Wednesday, June 03, 2015 09:21:11 PM Topi Pohjolainen wrote: > Shader programs are cached per stage (FS, VS, GS) using the > corresponding shader source identifier and compile time choices > as key. However, one not only stores the program binary but > a pair consisting of program binary and pro

Re: [Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-22 Thread Pohjolainen, Topi
On Mon, Jun 22, 2015 at 01:28:12PM +0300, Pohjolainen, Topi wrote: > On Thu, Jun 04, 2015 at 05:35:11PM -0700, Ben Widawsky wrote: > > On Wed, Jun 03, 2015 at 09:32:55PM +0300, Pohjolainen, Topi wrote: > > > On Wed, Jun 03, 2015 at 09:21:11PM +0300, Topi Pohjolainen wrote: > > > > Shader programs a

Re: [Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-22 Thread Pohjolainen, Topi
On Thu, Jun 04, 2015 at 05:35:11PM -0700, Ben Widawsky wrote: > On Wed, Jun 03, 2015 at 09:32:55PM +0300, Pohjolainen, Topi wrote: > > On Wed, Jun 03, 2015 at 09:21:11PM +0300, Topi Pohjolainen wrote: > > > Shader programs are cached per stage (FS, VS, GS) using the > > > corresponding shader sourc

Re: [Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-04 Thread Ben Widawsky
On Wed, Jun 03, 2015 at 09:32:55PM +0300, Pohjolainen, Topi wrote: > On Wed, Jun 03, 2015 at 09:21:11PM +0300, Topi Pohjolainen wrote: > > Shader programs are cached per stage (FS, VS, GS) using the > > corresponding shader source identifier and compile time choices > > as key. However, one not onl

Re: [Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-03 Thread Pohjolainen, Topi
On Wed, Jun 03, 2015 at 09:21:11PM +0300, Topi Pohjolainen wrote: > Shader programs are cached per stage (FS, VS, GS) using the > corresponding shader source identifier and compile time choices > as key. However, one not only stores the program binary but > a pair consisting of program binary and p

[Mesa-dev] [RFC] i965: Don't consider uniform value locations in program uploads

2015-06-03 Thread Topi Pohjolainen
Shader programs are cached per stage (FS, VS, GS) using the corresponding shader source identifier and compile time choices as key. However, one not only stores the program binary but a pair consisting of program binary and program data. The latter represents the store of constants (such as uniform