Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-13 Thread Jose Fonseca
On 09/07/15 22:05, Marek Olšák wrote: I'd like to discuss one more thing that will affect whether image slots will be global (shared by all shaders) or not. Which image unit an image uniform uses is not a compile-time thing, but it's specified later using glUniform1i. That means we need a per-sh

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-09 Thread Ilia Mirkin
On Thu, Jul 9, 2015 at 5:30 PM, Ilia Mirkin wrote: > On Thu, Jul 9, 2015 at 5:05 PM, Marek Olšák wrote: >> I'd like to discuss one more thing that will affect whether image >> slots will be global (shared by all shaders) or not. >> >> Which image unit an image uniform uses is not a compile-time t

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-09 Thread Ilia Mirkin
On Thu, Jul 9, 2015 at 5:05 PM, Marek Olšák wrote: > I'd like to discuss one more thing that will affect whether image > slots will be global (shared by all shaders) or not. > > Which image unit an image uniform uses is not a compile-time thing, > but it's specified later using glUniform1i. That m

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-09 Thread Marek Olšák
I'd like to discuss one more thing that will affect whether image slots will be global (shared by all shaders) or not. Which image unit an image uniform uses is not a compile-time thing, but it's specified later using glUniform1i. That means we need a per-shader table that maps image uniforms to g

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Roland Scheidegger
Am 07.07.2015 um 22:35 schrieb Jose Fonseca: > On 07/07/15 21:28, Ilia Mirkin wrote: >> On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca wrote: >>> I'm not experienced with the semantics around resources that can be >>> read/written by shaders, so I can't really make educated comments. >>> >>> But ove

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Ilia Mirkin
On Tue, Jul 7, 2015 at 4:35 PM, Jose Fonseca wrote: > On 07/07/15 21:28, Ilia Mirkin wrote: >> >> On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca wrote: >>> >>> I'm not experienced with the semantics around resources that can be >>> read/written by shaders, so I can't really make educated comments.

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Jose Fonseca
On 07/07/15 21:28, Ilia Mirkin wrote: On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca wrote: I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On 05/07/15 14:25, Marek Olš

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Ilia Mirkin
On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca wrote: > I'm not experienced with the semantics around resources that can be > read/written by shaders, so I can't really make educated comments. > > But overall this looks good to me FWIW. > > On 05/07/15 14:25, Marek Olšák wrote: >> >> From: Marek Olš

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Jose Fonseca
I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On 05/07/15 14:25, Marek Olšák wrote: From: Marek Olšák Other approaches are being considered: 1) Don't use resource

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-06 Thread Marek Olšák
On Sun, Jul 5, 2015 at 3:47 PM, Ilia Mirkin wrote: > On Sun, Jul 5, 2015 at 9:25 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> Other approaches are being considered: >> >> 1) Don't use resource wrappers (views) and pass all view parameters >>(format, layer range, level) to set_shader_ima

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-06 Thread Roland Scheidegger
Am 05.07.2015 um 15:47 schrieb Ilia Mirkin: > On Sun, Jul 5, 2015 at 9:25 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> Other approaches are being considered: >> >> 1) Don't use resource wrappers (views) and pass all view parameters >>(format, layer range, level) to set_shader_images just

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-05 Thread Ilia Mirkin
On Sun, Jul 5, 2015 at 9:25 AM, Marek Olšák wrote: > From: Marek Olšák > > Other approaches are being considered: > > 1) Don't use resource wrappers (views) and pass all view parameters >(format, layer range, level) to set_shader_images just like >set_vertex_buffers, set_constant_buffer,

[Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-05 Thread Marek Olšák
From: Marek Olšák Other approaches are being considered: 1) Don't use resource wrappers (views) and pass all view parameters (format, layer range, level) to set_shader_images just like set_vertex_buffers, set_constant_buffer, or even glBindImageTexture do. 2) Use pipe_sampler_view instead