Re: [Mesa-dev] [RFC][PATCH] gallivm: Avoid conflict with LLVM's definition of DEBUG

2015-05-28 Thread Michel Dänzer
On 28.05.2015 18:39, Jose Fonseca wrote: > Hi Michel, > > I'm sorry: I hadn't notice your review-request, and just pushed a > similar fix. No worries, though maybe this is an indication that it wasn't all that trivial after all. :) > I used push/pop_macro pragma instead. I think it's portable e

Re: [Mesa-dev] [RFC][PATCH] gallivm: Avoid conflict with LLVM's definition of DEBUG

2015-05-28 Thread Jose Fonseca
Hi Michel, I'm sorry: I hadn't notice your review-request, and just pushed a similar fix. I used push/pop_macro pragma instead. I think it's portable enough (at least gcc and msvc support it). Your's is probable more portable though. I'm OK either way. Like you said, this is a workaround

[Mesa-dev] [RFC][PATCH] gallivm: Avoid conflict with LLVM's definition of DEBUG

2015-05-28 Thread Michel Dänzer
From: Michel Dänzer Fixes build failure with --enable-debug: Compiling src/gallium/auxiliary/gallivm/lp_bld_misc.cpp ... In file included from llvm/include/llvm/Object/RelocVisitor.h:23:0, from llvm/include/llvm/DebugInfo/DIContext.h:21, from llvm/include/llvm