Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-14 Thread davyaxel
>I was planning to change platform_wayland.c not to use _DRI_IMAGE_USE_SHARE >when self sharing. But after looking more closely, it seems that >PIPE_BIND_SHARED >would be necessary for gallium drivers for self-sharing too. > >Since we want to enable tiling when we use self-sharing, my patch isn

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-14 Thread davyaxel
> On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák wrote: >> On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin >> wrote: Other than hybrid systems (of which there are none with i915 graphics), is there any case where __DRI_IMAGE_USE_SHARE can occur? >>> >>> You could do interesti

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-13 Thread Kristian Høgsberg
On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák wrote: > On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin > wrote: >>> Other than hybrid systems (of which >>> there are none with i915 graphics), is there any case where >>> __DRI_IMAGE_USE_SHARE can occur? >> >> You could do interesting things li

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-13 Thread Chad Versace
On 08/12/2013 03:15 PM, Stéphane Marchesin wrote: On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák wrote: On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin wrote: Other than hybrid systems (of which there are none with i915 graphics), is there any case where __DRI_IMAGE_USE_SHARE can occur?

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Stéphane Marchesin
On Mon, Aug 12, 2013 at 3:05 PM, Marek Olšák wrote: > On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin > wrote: >>> Other than hybrid systems (of which >>> there are none with i915 graphics), is there any case where >>> __DRI_IMAGE_USE_SHARE can occur? >> >> You could do interesting things li

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Marek Olšák
On Mon, Aug 12, 2013 at 11:36 PM, Stéphane Marchesin wrote: >> Other than hybrid systems (of which >> there are none with i915 graphics), is there any case where >> __DRI_IMAGE_USE_SHARE can occur? > > You could do interesting things like cross-process sharing with it. I > think it's worth doing i

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Dave Airlie
On Tue, Aug 13, 2013 at 7:36 AM, Stéphane Marchesin wrote: > On Mon, Aug 12, 2013 at 2:29 PM, Ian Romanick wrote: >> On 08/11/2013 03:50 AM, davya...@free.fr wrote: This looks good to me, but commit messages should have a prefix indicating which component is changed. In your case i

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread davyaxel
> On 08/11/2013 03:50 AM, davya...@free.fr wrote: >>> This looks good to me, but commit messages should have a prefix >>> indicating which component is changed. In your case it's "gallium:" >>> and "intel:", respectively. >>> >>> Marek >> >> >> Ok, I've suppressed some trailing spaces and changed

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Stéphane Marchesin
On Mon, Aug 12, 2013 at 2:29 PM, Ian Romanick wrote: > On 08/11/2013 03:50 AM, davya...@free.fr wrote: >>> >>> This looks good to me, but commit messages should have a prefix >>> indicating which component is changed. In your case it's "gallium:" >>> and "intel:", respectively. >>> >>> Marek >> >>

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Ian Romanick
On 08/11/2013 03:50 AM, davya...@free.fr wrote: This looks good to me, but commit messages should have a prefix indicating which component is changed. In your case it's "gallium:" and "intel:", respectively. Marek Ok, I've suppressed some trailing spaces and changed the commit message. And

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-12 Thread Ian Romanick
On 08/11/2013 02:32 AM, davya...@free.fr wrote: Hello, To enable using prime on Wayland, we need to have a way to create shareable textures. That's the purpose of __DRI_IMAGE_USE_SHARE and PIPE_BIND_SHARED, but these flags don't disable tiling. This patch change the behaviour of these flags so

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-11 Thread davyaxel
>This looks good to me, but commit messages should have a prefix >indicating which component is changed. In your case it's "gallium:" >and "intel:", respectively. > >Marek Ok, I've suppressed some trailing spaces and changed the commit message. >From f48fdb44d638ae850c7f3df36211b33788088927 Mon

Re: [Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-11 Thread Marek Olšák
This looks good to me, but commit messages should have a prefix indicating which component is changed. In your case it's "gallium:" and "intel:", respectively. Marek On Sun, Aug 11, 2013 at 11:32 AM, wrote: > Hello, > > To enable using prime on Wayland, we need to have a way to create shareable

[Mesa-dev] [Patch] Sharing flags should disable tiling

2013-08-11 Thread davyaxel
Hello, To enable using prime on Wayland, we need to have a way to create shareable textures. That's the purpose of __DRI_IMAGE_USE_SHARE and PIPE_BIND_SHARED, but these flags don't disable tiling. This patch change the behaviour of these flags so that they disable tiling. Disabling tiling is n