Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-17 Thread Ilia Mirkin
On Mon, Nov 16, 2015 at 11:44 AM, Ilia Mirkin wrote: > On Mon, Nov 16, 2015 at 11:42 AM, Samuel Iglesias Gonsálvez > wrote: >> >> >> On 16/11/15 17:34, Ilia Mirkin wrote: >>> On Mon, Nov 16, 2015 at 11:29 AM, Samuel Iglesias Gonsálvez >>> wrote: On 16/11/15 13:07, Tapani Pälli wro

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Samuel Iglesias Gonsálvez
On 16/11/15 17:34, Ilia Mirkin wrote: > On Mon, Nov 16, 2015 at 11:29 AM, Samuel Iglesias Gonsálvez > wrote: >> >> >> On 16/11/15 13:07, Tapani Pälli wrote: >>> >>> On 11/16/2015 01:35 PM, Tapani Pälli wrote: On 11/16/2015 01:29 PM, Samuel Iglesias Gonsálvez wrote: > Hello Ili

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Ilia Mirkin
On Mon, Nov 16, 2015 at 11:42 AM, Samuel Iglesias Gonsálvez wrote: > > > On 16/11/15 17:34, Ilia Mirkin wrote: >> On Mon, Nov 16, 2015 at 11:29 AM, Samuel Iglesias Gonsálvez >> wrote: >>> >>> >>> On 16/11/15 13:07, Tapani Pälli wrote: On 11/16/2015 01:35 PM, Tapani Pälli wrote: > >>

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Ilia Mirkin
On Mon, Nov 16, 2015 at 11:29 AM, Samuel Iglesias Gonsálvez wrote: > > > On 16/11/15 13:07, Tapani Pälli wrote: >> >> On 11/16/2015 01:35 PM, Tapani Pälli wrote: >>> >>> >>> On 11/16/2015 01:29 PM, Samuel Iglesias Gonsálvez wrote: Hello Ilia, Tapani: I have reproduced the issue with

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Samuel Iglesias Gonsálvez
On 16/11/15 13:07, Tapani Pälli wrote: > > On 11/16/2015 01:35 PM, Tapani Pälli wrote: >> >> >> On 11/16/2015 01:29 PM, Samuel Iglesias Gonsálvez wrote: >>> Hello Ilia, Tapani: >>> >>> I have reproduced the issue with a piglit test but not with the trace >>> uploaded in the bug report :-( >>> >>

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Tapani Pälli
On 11/16/2015 01:35 PM, Tapani Pälli wrote: On 11/16/2015 01:29 PM, Samuel Iglesias Gonsálvez wrote: Hello Ilia, Tapani: I have reproduced the issue with a piglit test but not with the trace uploaded in the bug report :-( The piglit test was: bin/arb_shader_storage_buffer_object-maxblocks

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Samuel Iglesias Gonsálvez
On 16/11/15 12:35, Tapani Pälli wrote: > > > On 11/16/2015 01:29 PM, Samuel Iglesias Gonsálvez wrote: >> Hello Ilia, Tapani: >> >> I have reproduced the issue with a piglit test but not with the trace >> uploaded in the bug report :-( >> >> The piglit test was: bin/arb_shader_storage_buffer_obj

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Tapani Pälli
On 11/16/2015 01:29 PM, Samuel Iglesias Gonsálvez wrote: Hello Ilia, Tapani: I have reproduced the issue with a piglit test but not with the trace uploaded in the bug report :-( The piglit test was: bin/arb_shader_storage_buffer_object-maxblocks I have upload a branch with some fixes at Igal

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Samuel Iglesias Gonsálvez
Hello Ilia, Tapani: I have reproduced the issue with a piglit test but not with the trace uploaded in the bug report :-( The piglit test was: bin/arb_shader_storage_buffer_object-maxblocks I have upload a branch with some fixes at Igalia's mesa repo: Git repo: https://github.com/Igalia/mesa.git

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-16 Thread Samuel Iglesias Gonsálvez
On 13/11/15 21:38, Ilia Mirkin wrote: > On Fri, Nov 13, 2015 at 2:37 PM, Ilia Mirkin wrote: >> Looks like valgrind hates this for some reason. I'm seeing lots of >> >> ==16821== Conditional jump or move depends on uninitialised value(s) >> ==16821==at 0xA074D09: glsl_type::record_compare(gls

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-13 Thread Ilia Mirkin
On Fri, Nov 13, 2015 at 2:37 PM, Ilia Mirkin wrote: > Looks like valgrind hates this for some reason. I'm seeing lots of > > ==16821== Conditional jump or move depends on uninitialised value(s) > ==16821==at 0xA074D09: glsl_type::record_compare(glsl_type const*) > const (glsl_types.cpp:783) >

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-13 Thread Ilia Mirkin
Looks like valgrind hates this for some reason. I'm seeing lots of ==16821== Conditional jump or move depends on uninitialised value(s) ==16821==at 0xA074D09: glsl_type::record_compare(glsl_type const*) const (glsl_types.cpp:783) Where line 783 is: if (this->fields.structure[i].precisi

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-11 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 06/11/15 13:03, Tapani Pälli wrote: > From: Iago Toral Quiroga > > We will need this later on when we implement proper support for > precision qualifiers in the drivers and also to do link time checks for > uniforms as indicated by the spec. > > This p

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-10 Thread Iago Toral
On Tue, 2015-11-10 at 12:41 +0200, Tapani Pälli wrote: > > On 11/10/2015 12:26 PM, Iago Toral wrote: > > On Fri, 2015-11-06 at 14:03 +0200, Tapani Pälli wrote: > >> From: Iago Toral Quiroga > >> > >> We will need this later on when we implement proper support for > >> precision qualifiers in the

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-10 Thread Tapani Pälli
On 11/10/2015 12:26 PM, Iago Toral wrote: On Fri, 2015-11-06 at 14:03 +0200, Tapani Pälli wrote: From: Iago Toral Quiroga We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec.

Re: [Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-10 Thread Iago Toral
On Fri, 2015-11-06 at 14:03 +0200, Tapani Pälli wrote: > From: Iago Toral Quiroga > > We will need this later on when we implement proper support for > precision qualifiers in the drivers and also to do link time checks for > uniforms as indicated by the spec. > > This patch also adds compile-ti

[Mesa-dev] [PATCH v5 5/7] glsl: Add precision information to ir_variable

2015-11-06 Thread Tapani Pälli
From: Iago Toral Quiroga We will need this later on when we implement proper support for precision qualifiers in the drivers and also to do link time checks for uniforms as indicated by the spec. This patch also adds compile-time checks for variables without precision information (currently, Mes