Re: [Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

2017-08-11 Thread Marek Olšák
On Wed, Aug 9, 2017 at 10:34 PM, Rob Herring wrote: > On Wed, Aug 9, 2017 at 3:19 PM, Marek Olšák wrote: >> You already know I can't accept the amdgpu part. > > You don't agree with my explanation in the other patch? OK. This patch is: Reviewed-by: Marek Olšák Marek __

Re: [Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

2017-08-09 Thread Rob Herring
On Wed, Aug 9, 2017 at 3:19 PM, Marek Olšák wrote: > You already know I can't accept the amdgpu part. You don't agree with my explanation in the other patch? > Anyway, I don't know if it's possible to keep the radeon part of the > patch, because there is some shared code you would need to keep a

Re: [Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

2017-08-09 Thread Marek Olšák
You already know I can't accept the amdgpu part. Anyway, I don't know if it's possible to keep the radeon part of the patch, because there is some shared code you would need to keep as well. Marek On Tue, Aug 8, 2017 at 12:58 AM, Rob Herring wrote: > Use the common pipe_screen ref counting. > >

[Mesa-dev] [PATCH v5 09/12] radeon: use common pipe_screen ref counting

2017-08-07 Thread Rob Herring
Use the common pipe_screen ref counting. radeon uses the common pipe_screen_{un}reference functions, but amdgpu is unique in its hashing the dev pointer rather than the fd, so the common fd hashing cannot be used. However, the same reference counting can be used instead of the private one. The mut