Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-05 Thread Pohjolainen, Topi
On Thu, Apr 05, 2018 at 04:11:33PM -0700, Nanley Chery wrote: > On Wed, Apr 04, 2018 at 07:40:43AM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 09:38:52PM -0700, Jason Ekstrand wrote: > > > On Tue, Apr 3, 2018 at 8:23 PM, Pohjolainen, Topi < > > > topi.pohjolai...@gmail.com> wrote: >

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-05 Thread Nanley Chery
On Wed, Apr 04, 2018 at 07:40:43AM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 09:38:52PM -0700, Jason Ekstrand wrote: > > On Tue, Apr 3, 2018 at 8:23 PM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Tue, Apr 03, 2018 at 02:55:31PM -0700, Jason Ekstrand wro

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Jason Ekstrand
On Tue, Apr 3, 2018 at 9:40 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Apr 03, 2018 at 09:38:52PM -0700, Jason Ekstrand wrote: > > On Tue, Apr 3, 2018 at 8:23 PM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Tue, Apr 03, 2018 at 02:55:31PM -0700

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 09:38:52PM -0700, Jason Ekstrand wrote: > On Tue, Apr 3, 2018 at 8:23 PM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Tue, Apr 03, 2018 at 02:55:31PM -0700, Jason Ekstrand wrote: > > > On Tue, Apr 3, 2018 at 8:05 AM, Pohjolainen, Topi < > > > topi.pohj

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Jason Ekstrand
On Tue, Apr 3, 2018 at 8:23 PM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Apr 03, 2018 at 02:55:31PM -0700, Jason Ekstrand wrote: > > On Tue, Apr 3, 2018 at 8:05 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Thu, Mar 29, 2018 at 10:58:40AM -0700

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 02:55:31PM -0700, Jason Ekstrand wrote: > On Tue, Apr 3, 2018 at 8:05 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > > gen10 can emit the clear color by setting it on a buffer somewhe

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Jason Ekstrand
On Tue, Apr 3, 2018 at 8:05 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > then adding only the address to the surface state. > > > > Thi

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Rafael Antognolli
On Tue, Apr 03, 2018 at 06:53:18PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 06:50:09PM +0300, Pohjolainen, Topi wrote: > > On Tue, Apr 03, 2018 at 08:43:54AM -0700, Rafael Antognolli wrote: > > > On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > > > > On Thu, Mar

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 06:50:09PM +0300, Pohjolainen, Topi wrote: > On Tue, Apr 03, 2018 at 08:43:54AM -0700, Rafael Antognolli wrote: > > On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > > > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > > > gen10 can e

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 08:43:54AM -0700, Rafael Antognolli wrote: > On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > > then add

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Rafael Antognolli
On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > then adding only the address to the surface state. > > > > This commit add support

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Tue, Apr 03, 2018 at 06:05:06PM +0300, Pohjolainen, Topi wrote: > On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > then adding only the address to the surface state. > > > > This commit add support

Re: [Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-04-03 Thread Pohjolainen, Topi
On Thu, Mar 29, 2018 at 10:58:40AM -0700, Rafael Antognolli wrote: > gen10 can emit the clear color by setting it on a buffer somewhere, and > then adding only the address to the surface state. > > This commit add support for that on isl_surf_fill_state, and if that is > requested, skip setting th

[Mesa-dev] [PATCH v5 06/19] intel/isl: Add support to emit clear value address.

2018-03-29 Thread Rafael Antognolli
gen10 can emit the clear color by setting it on a buffer somewhere, and then adding only the address to the surface state. This commit add support for that on isl_surf_fill_state, and if that is requested, skip setting the clear value itself. v2: Add assert to make sure we are at least on gen10.