Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-28 Thread Jason Ekstrand
On Mon, Sep 28, 2015 at 2:19 PM, Eduardo Lima Mitev wrote: > On 09/28/2015 08:25 PM, Jason Ekstrand wrote: >> Eduardo, >> Is there anything here still awaiting review? I thought I reviewed it all. >> --Jason >> > > Hi, > > Sorry for the delays, I'm on holidays for a couple weeks. > > Jason, all p

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-28 Thread Eduardo Lima Mitev
On 09/28/2015 08:25 PM, Jason Ekstrand wrote: > Eduardo, > Is there anything here still awaiting review? I thought I reviewed it all. > --Jason > Hi, Sorry for the delays, I'm on holidays for a couple weeks. Jason, all patches in the series are reviewed by you. Thanks! Mark, I guess your Test

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-28 Thread Jason Ekstrand
Eduardo, Is there anything here still awaiting review? I thought I reviewed it all. --Jason On Mon, Sep 28, 2015 at 10:57 AM, Mark Janes wrote: > Tested-by: Mark Janes > > Eduardo Lima Mitev writes: > >> This is a new version of the series that attempt to fix the regression >> reported at: >>

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-28 Thread Mark Janes
Tested-by: Mark Janes Eduardo Lima Mitev writes: > This is a new version of the series that attempt to fix the regression > reported at: > > https://bugs.freedesktop.org/show_bug.cgi?id=91582 > > The review by Jason helped me uncover the fact that the following 3 dEQP > tests are buggy: > > d

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-25 Thread Crisan, Alex
Sure Mark, I will work with Kaveh on the next steps. Is it safe to assume these tests will be buggy on any platforms? -Original Message- From: Janes, Mark A Sent: Friday, September 25, 2015 7:41 AM To: Eduardo Lima Mitev; mesa-dev@lists.freedesktop.org Cc: Eduardo Lima Mitev; ja...@jleks

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-25 Thread Jason Ekstrand
On Fri, Sep 25, 2015 at 9:06 AM, Crisan, Alex wrote: > Sure Mark, I will work with Kaveh on the next steps. Is it safe to assume > these tests will be buggy on any platforms? Yes. The test is testing for GL API errors and its behavior should be completely independent of platform. --Jason > ---

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-25 Thread Mark Janes
This patch series fixes a few dEQP tests on braswell. The rest of the platform are unaffected, according to my tests. deqp-gles2.functional.negative_api.texture.teximage2d_invalid_type deqp-gles2.functional.negative_api.texture.teximage2d_invalid_internalformat deqp-gles3.functional.negative_api.

Re: [Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-24 Thread Jason Ekstrand
On Thu, Sep 24, 2015 at 1:57 AM, Eduardo Lima Mitev wrote: > This is a new version of the series that attempt to fix the regression > reported at: > > https://bugs.freedesktop.org/show_bug.cgi?id=91582 > > The review by Jason helped me uncover the fact that the following 3 dEQP > tests are buggy

[Mesa-dev] [PATCH v5 0/3] A couple of fixes for Tex(Sub)Image error checks

2015-09-24 Thread Eduardo Lima Mitev
This is a new version of the series that attempt to fix the regression reported at: https://bugs.freedesktop.org/show_bug.cgi?id=91582 The review by Jason helped me uncover the fact that the following 3 dEQP tests are buggy: dEQP-GLES2.functional.negative_api.texture.texsubimage2d_neg_offset d