Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

2015-10-30 Thread Christian König
On 29.10.2015 18:40, Julien Isorce wrote: And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType whi

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

2015-10-30 Thread Julien Isorce
Ok I'll make a separate patch for the add of errors checks and add the break in the loop. Thx Julien -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: 29 October 2015 22:03 To: Julien Isorce Cc: ML mesa-dev Subject: Re: [Mesa-dev] [PATCH v4 8/9]

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

2015-10-29 Thread Emil Velikov
Hi Julien, One can separate the errors checks and get those separately (+stable). I'll let others be the judge of that - I'm just going to point the sections I have in mind. On 29 October 2015 at 17:40, Julien Isorce wrote: > @@ -73,6 +76,10 @@ vlVaBufferSetNumElements(VADriverContextP ctx, VAB

[Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

2015-10-29 Thread Julien Isorce
And apply relatives change to: vlVaBufferSetNumElements vlVaCreateBuffer vlVaMapBuffer vlVaUnmapBuffer vlVaDestroyBuffer vlVaPutImage It is unfortunate that there is no proper va buffer type and struct for this. Only possible to use VAImageBufferType which is normally used for normal user data arr