Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-15 Thread Sergii Romantsov
Hello, Kenneth. Thanks for remarks. Will update patch soon and also will try to look on 3DSTATE_SO_BUFFER. On Tue, Aug 14, 2018 at 8:39 PM, Kenneth Graunke wrote: > Hi Sergii, > > This patch causes 2,384 failures in CI. The issue is that we're > apparently trying to allocate 0 size BOs in some

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-14 Thread Kenneth Graunke
Hi Sergii, This patch causes 2,384 failures in CI. The issue is that we're apparently trying to allocate 0 size BOs in some places, which are getting rounded up to 4096 with the current code...but with your patch, we get ALIGN(0, 4096) == 0, and assert(bo_size) triggers. We might want to continu

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-14 Thread Sergii Romantsov
Hello, seems some part of the World is still may waiting for a possibility to play Dying Light... till pushed :) On Mon, Aug 6, 2018 at 4:26 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 06/08/18 13:41, Sergii Romantsov wrote: > >> Kernel (for ppgtt) requires memory address t

Re: [Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-06 Thread Lionel Landwerlin
On 06/08/18 13:41, Sergii Romantsov wrote: Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson

[Mesa-dev] [PATCH v4 1/2] intel/ppgtt: memory address alignment

2018-08-06 Thread Sergii Romantsov
Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson). -v4: changes related to PAGE_SIZE moved to