Re: [Mesa-dev] [PATCH v3 5/7] ac: add LLVM build functions for subgroup instrinsics

2018-04-15 Thread Nicolai Hähnle
I'm a bit late, but just some stylistic nitpicks for the future: As a general stylistic note, prefer `false' as the last argument to LLVMConstInt (since it's a boolean, whether to sign-extend). [snip] +{ + ac_build_optimization_barrier(ctx, &src); + LLVMValueRef result; + LL

[Mesa-dev] [PATCH v3 5/7] ac: add LLVM build functions for subgroup instrinsics

2018-04-10 Thread Daniel Schürmann
Co-authored-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 456 + src/amd/common/ac_llvm_build.h | 30 ++- 2 files changed, 485 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index 2fb8aea