Re: [Mesa-dev] [PATCH v3 2/4] gm107/ir: add support for OP_XMAD on GM107+

2018-08-10 Thread Karol Herbst
On Fri, Aug 10, 2018 at 8:36 PM, Rhys Perry wrote: > Yeah, "immediate = false;" looks incorrect. > > Looking at nvdisasm and the placement of XMAD's various atoms, it seems it > can only have 16-bit unsigned immediates, so envydis and the patches > should probably be updated. > > As for how multip

Re: [Mesa-dev] [PATCH v3 2/4] gm107/ir: add support for OP_XMAD on GM107+

2018-08-10 Thread Rhys Perry
Yeah, "immediate = false;" looks incorrect. Looking at nvdisasm and the placement of XMAD's various atoms, it seems it can only have 16-bit unsigned immediates, so envydis and the patches should probably be updated. As for how multiplication by immediates work with mul/mad -> XMAD conversion, the

Re: [Mesa-dev] [PATCH v3 2/4] gm107/ir: add support for OP_XMAD on GM107+

2018-08-09 Thread Karol Herbst
On Mon, Jul 23, 2018 at 12:40 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 65 > ++ > .../nouveau/codegen/nv50_ir_target_gm107.cpp | 6 +- > .../nouveau/codegen/nv50_ir_target_nvc0.cpp| 1 + >

[Mesa-dev] [PATCH v3 2/4] gm107/ir: add support for OP_XMAD on GM107+

2018-07-23 Thread Rhys Perry
Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 65 ++ .../nouveau/codegen/nv50_ir_target_gm107.cpp | 6 +- .../nouveau/codegen/nv50_ir_target_nvc0.cpp| 1 + 3 files changed, 71 insertions(+), 1 deletion(-) diff --git a/src/g