Re: [Mesa-dev] [PATCH v3 19/23] glsl: Add image built-in function generator.

2013-12-18 Thread Paul Berry
On 18 December 2013 07:14, Francisco Jerez wrote: > Paul Berry writes: > >[...] > > This is definitely an improvement, thanks. I still think there are some > > minor tweaks that would reduce duplication of information, though: > > > > - Precompute the value (glsl ? IMAGE_FUNCTION_EMIT_STUB : 0)

Re: [Mesa-dev] [PATCH v3 19/23] glsl: Add image built-in function generator.

2013-12-18 Thread Francisco Jerez
Paul Berry writes: >[...] > This is definitely an improvement, thanks. I still think there are some > minor tweaks that would reduce duplication of information, though: > > - Precompute the value (glsl ? IMAGE_FUNCTION_EMIT_STUB : 0) rather than > duplicating it at each add_image_function call si

Re: [Mesa-dev] [PATCH v3 19/23] glsl: Add image built-in function generator.

2013-12-17 Thread Paul Berry
On 17 December 2013 02:10, Francisco Jerez wrote: > Because of the combinatorial explosion of different image built-ins > with different image dimensionalities and base data types, enumerating > all the 242 possibilities would be annoying and a waste of .text > space. Instead use a special path

[Mesa-dev] [PATCH v3 19/23] glsl: Add image built-in function generator.

2013-12-17 Thread Francisco Jerez
Because of the combinatorial explosion of different image built-ins with different image dimensionalities and base data types, enumerating all the 242 possibilities would be annoying and a waste of .text space. Instead use a special path in the built-in builder that loops over all the known image