Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-21 Thread Ilia Mirkin
Sooo I know I'm the one who suggested this change in the first place. But having slept on it, I think this is wrong. The point of a CmpInstruction is when you're comparing two things and you need a comparison operator and stuff like that. This is a much simpler situation -- you can only have a

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Samuel Pitoiset
On 02/17/2016 10:36 PM, Ilia Mirkin wrote: On Wed, Feb 17, 2016 at 4:36 PM, Samuel Pitoiset wrote: On 02/17/2016 10:33 PM, Ilia Mirkin wrote: Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) Pretty sure that SELP won't be usefu

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 4:36 PM, Samuel Pitoiset wrote: > > > On 02/17/2016 10:33 PM, Ilia Mirkin wrote: >> >> Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? >> Perhaps just not implemented yet...) > > > Pretty sure that SELP won't be useful for shared+atomics on GK110+ bec

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Samuel Pitoiset
On 02/17/2016 10:33 PM, Ilia Mirkin wrote: Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) Pretty sure that SELP won't be useful for shared+atomics on GK110+ because I don't use it GK104 IIRC. On Wed, Feb 17, 2016 at 4:27 PM, S

Re: [Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Ilia Mirkin
Fix gk110 emitter for the updated logic? (Looks like no SELP on GM107? Perhaps just not implemented yet...) On Wed, Feb 17, 2016 at 4:27 PM, Samuel Pitoiset wrote: > This OP_SELP insn will be used to handle compare and swap subops. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/

[Mesa-dev] [PATCH v3 12/14] nv50/ir: make OP_SELP a compare instruction

2016-02-17 Thread Samuel Pitoiset
This OP_SELP insn will be used to handle compare and swap subops. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 8 src/gallium/drivers/nouveau/codegen/nv50_ir_inlines.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff