Re: [Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-26 Thread Jason Ekstrand
On Wed, Oct 26, 2016 at 3:47 PM, Nanley Chery wrote: > On Thu, Oct 06, 2016 at 03:21:54PM -0700, Nanley Chery wrote: > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > > demos. > > After attempting to enable fast depth clears in more areas, I noticed > something possi

Re: [Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-26 Thread Nanley Chery
On Thu, Oct 06, 2016 at 03:21:54PM -0700, Nanley Chery wrote: > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > demos. After attempting to enable fast depth clears in more areas, I noticed something possibly worth sharing. Most of the performance gain from this patch is

Re: [Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-07 Thread Chad Versace
On Thu 06 Oct 2016, Jason Ekstrand wrote: > Nice and clean!  R-b still applies. > > I think I've reviewed everything now.  If there's still something missing, let > me know.  May also want to give Chad a chance. I agree. Nice and clean. Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-06 Thread Jason Ekstrand
Nice and clean! R-b still applies. I think I've reviewed everything now. If there's still something missing, let me know. May also want to give Chad a chance. On Thu, Oct 6, 2016 at 3:21 PM, Nanley Chery wrote: > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > dem

[Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-06 Thread Nanley Chery
Provides an FPS increase of ~30% on the Sascha triangle and multisampling demos. Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand (v2) --- v3. Emit required clear_params packet (Chad) Share clear_params code path IVB+ (Jason) src/intel/vulkan/anv_pass.c| 13 + s