Re: [Mesa-dev] [PATCH v3 08/48] intel/eu: Just modify the offset in brw_broadcast

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 3:18 AM, Iago Toral wrote: > I am not sure I get the purpose of this, there is nothing wrong with > the change, but the subject suggests that was so that we modified that > offset only inside brw_broadcast()... but that was already happening > and in fact this patch only c

Re: [Mesa-dev] [PATCH v3 08/48] intel/eu: Just modify the offset in brw_broadcast

2017-10-26 Thread Iago Toral
I am not sure I get the purpose of this, there is nothing wrong with the change, but the subject suggests that was so that we modified that offset only inside brw_broadcast()... but that was already happening and in fact this patch only changes code inside that function so I wonder if there is some

[Mesa-dev] [PATCH v3 08/48] intel/eu: Just modify the offset in brw_broadcast

2017-10-25 Thread Jason Ekstrand
This means we have to drop const from a variable but it also means that 100% of the code which deals with the offset limit is in one place. --- src/intel/compiler/brw_eu_emit.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel