Re: [Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-27 Thread Rafael Antognolli
On Tue, Feb 27, 2018 at 05:00:24PM -0800, Jordan Justen wrote: > On 2018-02-26 21:35:42, Jason Ekstrand wrote: > > On Mon, Feb 26, 2018 at 8:12 PM, Jordan Justen > > wrote: > > > > > On 2018-02-26 17:08:12, Jason Ekstrand wrote: > > > > On Mon, Feb 26, 2018 at 1:14 PM, Jordan Justen < > > > jorda

Re: [Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-27 Thread Jordan Justen
On 2018-02-26 21:35:42, Jason Ekstrand wrote: > On Mon, Feb 26, 2018 at 8:12 PM, Jordan Justen > wrote: > > > On 2018-02-26 17:08:12, Jason Ekstrand wrote: > > > On Mon, Feb 26, 2018 at 1:14 PM, Jordan Justen < > > jordan.l.jus...@intel.com> > > > wrote: > > > > > > > On 2018-02-21 13:45:15, Rafa

Re: [Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-26 Thread Jason Ekstrand
On Mon, Feb 26, 2018 at 8:12 PM, Jordan Justen wrote: > On 2018-02-26 17:08:12, Jason Ekstrand wrote: > > On Mon, Feb 26, 2018 at 1:14 PM, Jordan Justen < > jordan.l.jus...@intel.com> > > wrote: > > > > > On 2018-02-21 13:45:15, Rafael Antognolli wrote: > > > > + bool use_clear_address; > > > >

Re: [Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-26 Thread Jordan Justen
On 2018-02-26 17:08:12, Jason Ekstrand wrote: > On Mon, Feb 26, 2018 at 1:14 PM, Jordan Justen > wrote: > > > On 2018-02-21 13:45:15, Rafael Antognolli wrote: > > > + bool use_clear_address; > > > > I'm still wondering about this field. I think at the end we can just a > > assume that if gen >=

Re: [Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-26 Thread Jason Ekstrand
On Mon, Feb 26, 2018 at 1:14 PM, Jordan Justen wrote: > On 2018-02-21 13:45:15, Rafael Antognolli wrote: > > gen10 can emit the clear color by setting it on a buffer somewhere, and > > then adding only the address to the surface state. > > > > This commit add support for that on isl_surf_fill_sta

Re: [Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-26 Thread Jordan Justen
On 2018-02-21 13:45:15, Rafael Antognolli wrote: > gen10 can emit the clear color by setting it on a buffer somewhere, and > then adding only the address to the surface state. > > This commit add support for that on isl_surf_fill_state, and if that is > requested, skip setting the clear value itse

[Mesa-dev] [PATCH v3 06/13] intel/isl: Add support to emit clear value address.

2018-02-21 Thread Rafael Antognolli
gen10 can emit the clear color by setting it on a buffer somewhere, and then adding only the address to the surface state. This commit add support for that on isl_surf_fill_state, and if that is requested, skip setting the clear value itself. v2: Add assert to make sure we are at least on gen10.