Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-30 Thread Iago Toral
I posted comments in patches 39 and 43, but otherwise patches 39-48 are: Reviewed-by: Iago Toral Quiroga Iago On Fri, 2017-10-27 at 13:57 +0200, Iago Toral wrote: > I dropped a few more comments on patches 18-20, 23, 25, 29-31, 34 and > 38 but nothing major in general. > > I have doubts that p

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-27 Thread Iago Toral
I dropped a few more comments on patches 18-20, 23, 25, 29-31, 34 and 38 but nothing major in general. I have doubts that patch 20 isn't working around some other bug and 38 scares me a little bit but I guess if Jenkins is happy I shouldn't worry too much. Otherwise, patches 16-38 are: Reviewed-

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 5:15 AM, Iago Toral wrote: > I left a few minor comments in patches 1, 2, 8 and 14. Otherwise > patches 1-2, 4-5 and 7-14 (3 and 6 already have Rb) are: > > Reviewed-by: Iago Toral Quiroga > > I feel like patches 10, 11 could maybe use another extra review if > there is s

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-26 Thread Iago Toral
I left a few minor comments in patches 1, 2, 8 and 14. Otherwise patches 1-2, 4-5 and 7-14 (3 and 6 already have Rb) are: Reviewed-by: Iago Toral Quiroga I feel like patches 10, 11 could maybe use another extra review if there is someone who wants to do it, since I am not very familiar with how

[Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-25 Thread Jason Ekstrand
This series is a third respin of my subgroups prerequisites series that that I sent out a few weeks ago. Not a whole lot has changed but there are some new patches. Primarily, 1) Some patches which were reviewed by Matt and Lionel were pushed and are no longer in the series. Thanks guys!