Re: [Mesa-dev] [PATCH v3] r600g: Implement GL_ARB_draw_indirect for EG/CM

2015-02-07 Thread Marek Olšák
I'm not sure if I fully understand, but it seems the problem is that the start/index_bias is copied to SQ_VTX_BASE_VTX and not VGT_INDX_OFFSET. I guess you can avoid using BASE_VTX by setting fetch_type=NO_INDEX_OFFSET, right? If yes, then there is a simple solution: The COPY_DW packet. It can be u

Re: [Mesa-dev] [PATCH v3] r600g: Implement GL_ARB_draw_indirect for EG/CM

2015-02-06 Thread Glenn Kennard
On Fri, 06 Feb 2015 17:08:46 +0100, Marek Olšák wrote: Please bump the size of vgt_state for the SQ_VTX_BASE_VTX_LOC register. It's set by r600_init_atom in r600_state.c and evergreen_state.c Please bump R600_MAX_DRAW_CS_DWORDS. It's an upper bound of how many dwords draw_vbo can emit. Than

Re: [Mesa-dev] [PATCH v3] r600g: Implement GL_ARB_draw_indirect for EG/CM

2015-02-06 Thread Marek Olšák
Please bump the size of vgt_state for the SQ_VTX_BASE_VTX_LOC register. It's set by r600_init_atom in r600_state.c and evergreen_state.c Please bump R600_MAX_DRAW_CS_DWORDS. It's an upper bound of how many dwords draw_vbo can emit. I don't understand what get_vfetch_type is good for. Could you pl

[Mesa-dev] [PATCH v3] r600g: Implement GL_ARB_draw_indirect for EG/CM

2015-02-05 Thread Glenn Kennard
Requires Evergreen/Cayman and radeon kernel module 2.41.0 or newer. Signed-off-by: Glenn Kennard --- Changes since v2: * Fix failing arb_draw_indirect-vertexid piglit test cases. * Ensure start_instance, base_vertex, index_offset are reset when switching back to direct draws. * Juggled some hea