Re: [Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-27 Thread Lionel Landwerlin
Hey Sergii, Sorry for the late answer. For the sake of clarity, I would split the changes (4096->PAGE_SIZE) and the actual bug fix into 2 different patches. I don't have see a problem with the PAGE_SIZE change. Thanks a lot, - Lionel On 25/07/18 14:24, Sergii Romantsov wrote: Sorry, do we

Re: [Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-27 Thread Sergii Romantsov
Hello, Kenneth and Lionel. Maybe, could we make a final review? On Wed, Jul 25, 2018 at 4:24 PM, Sergii Romantsov < sergii.romant...@globallogic.com> wrote: > Sorry, > do we have any objections about PAGE_SIZE usage instead of 4096? > > And what do you think if, maybe, some auto Intel-internal te

Re: [Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Sorry, do we have any objections about PAGE_SIZE usage instead of 4096? And what do you think if, maybe, some auto Intel-internal tests to run with that patch? On Wed, Jul 25, 2018 at 1:21 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Kernel (for ppgtt) requires memory address to

[Mesa-dev] [PATCH v3] intel/ppgtt: memory address alignment

2018-07-25 Thread Sergii Romantsov
Kernel (for ppgtt) requires memory address to be aligned to page size (4096). -v2: added marking that also fixes initial commit 01058a552294. -v3: numbers replaced by PAGE_SIZE; buffer-object size is aligned instead of alignment of offsets (Chris Wilson). Bugzilla: https://bugs.freedesktop.org/sh