Forget the previous email. It was an error on the test. The texture
barrier works fine.
Sorry for the noise.
BR
On 08/07/16 15:58, Alejandro Piñeiro wrote:
> Hi, today I was updating the piglit test, as I got a detailed review.
> While testing the changes, I found that there are some parameters
Hi, today I was updating the piglit test, as I got a detailed review.
While testing the changes, I found that there are some parameters
combinations that are still not passing. They are related to the number
of draw passes (or in other words, the number of glDrawElements calls
for the same vertices
On 30/06/16 23:16, Francisco Jerez wrote:
> Alejandro Piñeiro writes:
>
>> Fixes:
>> GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass
>>
>> On Haswell, Broadwell and Skylake (note that in order to execute that
>> test, it is needed to override GL and GLSL versions).
>>
>> On gen6 this test was
Jason Ekstrand writes:
> On Jun 30, 2016 9:25 PM, "Francisco Jerez" wrote:
>>
>> Jason Ekstrand writes:
>>
>> > Fwiw, I very much like the way I did this in the Vulkan driver where it
>> > splits it into two pipe controls automatically based on the input bits.
>> > (Look at genX_cmd_buffer.c cm
On Jun 30, 2016 9:25 PM, "Francisco Jerez" wrote:
>
> Jason Ekstrand writes:
>
> > Fwiw, I very much like the way I did this in the Vulkan driver where it
> > splits it into two pipe controls automatically based on the input bits.
> > (Look at genX_cmd_buffer.c cmd_buffer_apply_pipe_flushes.) I
Jason Ekstrand writes:
> Fwiw, I very much like the way I did this in the Vulkan driver where it
> splits it into two pipe controls automatically based on the input bits.
> (Look at genX_cmd_buffer.c cmd_buffer_apply_pipe_flushes.) I very much
> doubt that this is the only place we have this pro
Alejandro Piñeiro writes:
> Fixes:
> GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass
>
> On Haswell, Broadwell and Skylake (note that in order to execute that
> test, it is needed to override GL and GLSL versions).
>
> On gen6 this test was already working without this change. It keeps
> wor
Ok, thanks for the pointers. Will take a look tomorrow (is 21:00 here).
Btw, what do you prefer? To fix it first on the texture barrier with a
patch like this, and then import Vulkan's? or forget about fixing with
the current status and go directly to import Vulkan's approach?
BR
On 30/06/16 16:
Fwiw, I very much like the way I did this in the Vulkan driver where it
splits it into two pipe controls automatically based on the input bits.
(Look at genX_cmd_buffer.c cmd_buffer_apply_pipe_flushes.) I very much
doubt that this is the only place we have this problem in the GL driver.
We should
Fixes:
GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass
On Haswell, Broadwell and Skylake (note that in order to execute that
test, it is needed to override GL and GLSL versions).
On gen6 this test was already working without this change. It keeps
working after it.
This commit replaces the c
10 matches
Mail list logo
