Re: [Mesa-dev] [PATCH v3] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-07-08 Thread asimiklit.work
Hello, Sorry for late response. I was on vacation. I am glad that this fix is ok. Thanks a lot for your review. Regards, Andrii. On 2018-06-25 12:11 PM, Iago Toral wrote: Thanks for testing Mark. Andrii, I'll add my Reviewed-by and and push the patch to master later today (I'll also queue it

Re: [Mesa-dev] [PATCH v3] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-25 Thread Iago Toral
Thanks for testing Mark. Andrii, I'll add my Reviewed-by and and push the patch to master later today (I'll also queue it for the next stable release). Thanks for fixing this! Iago On Fri, 2018-06-22 at 13:18 -0700, Mark Janes wrote: > Tested-by: Mark Janes > > Iago Toral writes: > > > Than

Re: [Mesa-dev] [PATCH v3] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-22 Thread Mark Janes
Tested-by: Mark Janes Iago Toral writes: > Thanks Andrii, this version looks good to me. > > Mark: this change fixes a GPU hang in sandy bridge with geometry > shaders (the change itself affects a path in the driver that is only > executed in SNB with GS, so nothing else is affected). While I t

Re: [Mesa-dev] [PATCH v3] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-22 Thread Mark Janes
Hi Iago, It is usually safe to push changes to CI which provoke GPU hangs. Occasionally, systems do not recover, so I appreciate the extra notification. I've sent this commit for testing and will let you know how it goes. -Mark Iago Toral writes: > Thanks Andrii, this version looks good to me

Re: [Mesa-dev] [PATCH v3] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-22 Thread Iago Toral
Thanks Andrii, this version looks good to me. Mark: this change fixes a GPU hang in sandy bridge with geometry shaders (the change itself affects a path in the driver that is only executed in SNB with GS, so nothing else is affected). While I think the change in here is correct according to the PR

[Mesa-dev] [PATCH v3] i965/gen6/gs: Handle case where a GS doesn't allocate VUE

2018-06-22 Thread Andrii Simiklit
We can not use the VUE Dereference flags combination for EOT message under ILK and SNB because the threads are not initialized there with initial VUE handle unlike Pre-IL. So to avoid GPU hangs on SNB and ILK we need to avoid usage of the VUE Dereference flags combination. (Was tested only on SNB b