Re: [Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Eduardo Lima Mitev
Pushed: https://cgit.freedesktop.org/mesa/mesa/commit/?id=43c6f3f82f62f28dc97d195750ba25c88051b64e I edited a bit the commit message before pushing, to wrap lines. We try to avoid lines longer than 72 ~ 80 columns. Thanks, Eduardo On 03/23/2016 06:13 PM, Lars Hamre wrote: Thanks! Will do in

Re: [Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Lars Hamre
Thanks! Will do in the future. Regards, Lars On Wed, Mar 23, 2016 at 1:08 PM, Eduardo Lima Mitev wrote: > Hi Lars, > > I suppose you need help pushing your patch upstream. I will do it. > > As a note for the future, once you get a formal Review-by to a patch, it > is not necessary to send a new

Re: [Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Eduardo Lima Mitev
Hi Lars, I suppose you need help pushing your patch upstream. I will do it. As a note for the future, once you get a formal Review-by to a patch, it is not necessary to send a new version only to add the tag. You can instead ask directly someone with committing rights to merge it for you. ch

[Mesa-dev] [PATCH v3] compiler/glsl: allow sequence op as a const expr in gles 1.0

2016-03-23 Thread Lars Hamre
v3: Added reviewed-by tag v2: Fixed regression pointed out by Eduardo Lima Mitev Allow the sequence operator to be a constant expression in GLSL ES versions prior to GLSL ES 3.0 Fixes the following piglit test: /all/spec/glsl-es-1.0/compiler/array-sized-by-sequence-in-parenthesis.vert