Re: [Mesa-dev] [PATCH v3] Fixing an x86 FPU bug.

2015-02-17 Thread Predut, Marius
> -Original Message- > From: Brian Paul [mailto:bri...@vmware.com] > Sent: Thursday, February 12, 2015 10:24 PM > To: Predut, Marius; mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v3] Fixing an x86 FPU bug. > > I have a few concerns about thi

Re: [Mesa-dev] [PATCH v3] Fixing an x86 FPU bug.

2015-02-12 Thread Brian Paul
I have a few concerns about this patch. Firstly, including prog_parameter.h from macros.h feels wrong. Macros are a lower-level concept than program parameters so the "lower" thing shouldn't be including the "higher" thing. Instead of using gl_constant_value everywhere, why not use the fi_ty

[Mesa-dev] [PATCH v3] Fixing an x86 FPU bug.

2015-02-12 Thread marius . predut
From: Marius Predut On 32-bit, for floating point operations is used x86 FPU registers instead SSE, reason for when reinterprets an integer as a float result is unexpected (modify floats when they are written to memory). The defect was checked with and without -O3 compiler flag This patch is ba