Re: [Mesa-dev] [PATCH v2 8/9] python: Rework bytes/unicode string handling

2018-08-09 Thread Dylan Baker
This doesn't work with python 2. It's also pointed out to me that we don't handle translations in meson at all... Here's the traceback: make[5]: Entering directory '/home/jenkins/workspace/Leeroy_3/repos/mesa/build_m64/src/util/xmlpool' Updating (ca) ca/LC_MESSAGES/options.mo from /home/jenkins/

[Mesa-dev] [PATCH v2 8/9] python: Rework bytes/unicode string handling

2018-08-09 Thread Mathieu Bridon
In both Python 2 and 3, opening a file without specifying the mode will open it for reading in text mode ('r'). On Python 2, the read() method of a file object opened in mode 'r' will return byte strings, while on Python 3 it will return unicode strings. Explicitly specifying the binary mode ('rb