Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-07-01 Thread Roland Scheidegger
Am 01.07.2014 16:25, schrieb Ilia Mirkin: > On Tue, Jul 1, 2014 at 8:39 AM, Roland Scheidegger wrote: >> Am 30.06.2014 19:43, schrieb Ilia Mirkin: >>> On Sat, Jun 28, 2014 at 8:44 AM, Roland Scheidegger >>> wrote: 3-4 look alright to me. >>> >>> Does this count as a R-b? Looks like the core

Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-07-01 Thread Ilia Mirkin
On Tue, Jul 1, 2014 at 8:39 AM, Roland Scheidegger wrote: > Am 30.06.2014 19:43, schrieb Ilia Mirkin: >> On Sat, Jun 28, 2014 at 8:44 AM, Roland Scheidegger >> wrote: >>> 3-4 look alright to me. >> >> Does this count as a R-b? Looks like the core changes have landed, so >> I'm going to be lookin

Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-07-01 Thread Roland Scheidegger
Am 30.06.2014 19:43, schrieb Ilia Mirkin: > On Sat, Jun 28, 2014 at 8:44 AM, Roland Scheidegger > wrote: >> 3-4 look alright to me. > > Does this count as a R-b? Looks like the core changes have landed, so > I'm going to be looking to push all this out ~tomorrow. > >> I wonder if the cap name i

Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-06-30 Thread Ilia Mirkin
On Sat, Jun 28, 2014 at 8:44 AM, Roland Scheidegger wrote: > 3-4 look alright to me. Does this count as a R-b? Looks like the core changes have landed, so I'm going to be looking to push all this out ~tomorrow. > I wonder if the cap name is actually "correct" > or if it should have some STREAM_O

Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-06-28 Thread Marek Olšák
We already have PIPE_CAP_GLSL_FEATURE_LEVEL. Once everybody (who can) supports GLSL 4.00, we can drop some caps in favor of that. Marek On Sat, Jun 28, 2014 at 2:44 PM, Roland Scheidegger wrote: > 3-4 look alright to me. I wonder if the cap name is actually "correct" > or if it should have some

Re: [Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-06-28 Thread Roland Scheidegger
3-4 look alright to me. I wonder if the cap name is actually "correct" or if it should have some STREAM_OUT in it. But doesn't really matter I guess. Longer term I think we might want to merge some caps. Everybody (supporting stream out) will either support 1 or 4 streams along with other functiona

[Mesa-dev] [PATCH v2 4/9] gallium: add a cap for max vertex streams

2014-06-27 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Brian Paul --- v1 -> v2: - add an assert to make sure it's <= 4 - add a note in docs about expected values src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/g