Re: [Mesa-dev] [PATCH v2 4/7] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

2016-09-23 Thread Jason Ekstrand
On Sep 23, 2016 10:14 PM, "Nanley Chery" wrote: > > On Mon, Sep 12, 2016 at 05:58:21PM -0700, Jason Ekstrand wrote: > > HiZ buffers can be multisampled and, on BDW+, simply using interleaved > > As stated in your comment in the second-to-last hunk, this is actually > true for all platforms pre-SKL

Re: [Mesa-dev] [PATCH v2 4/7] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

2016-09-23 Thread Nanley Chery
On Mon, Sep 12, 2016 at 05:58:21PM -0700, Jason Ekstrand wrote: > HiZ buffers can be multisampled and, on BDW+, simply using interleaved As stated in your comment in the second-to-last hunk, this is actually true for all platforms pre-SKL. > multisampling with a compression block size of 8x4 samp

[Mesa-dev] [PATCH v2 4/7] intel/isl: Allow multisampling with ISL_FORMAT_HiZ

2016-09-12 Thread Jason Ekstrand
HiZ buffers can be multisampled and, on BDW+, simply using interleaved multisampling with a compression block size of 8x4 samples yields the correct HiZ surface size calculations. Unfortunately, choose_msaa_layout was rejecting multisampled HiZ buffers because of format checks. Now that we have a