On 07/11/2018 10:53 AM, Bas Nieuwenhuizen wrote:
Don't we need to disable predication too for the PipelineBarriers when
a layout change happens?
I don't think. Shouldn't the app handle this correctly? If a
CmdPipelineBarrier() is between Begin()/End() it will be skipped, that's it?
Also
Don't we need to disable predication too for the PipelineBarriers when
a layout change happens?
Also in cases the barrier or a blit/copy does different predication,
do we not need to do si_emit_set_predication_state again as the state
was overridden?
On Mon, Jul 9, 2018 at 2:57 PM, Samuel Pitoise
On 07/09/2018 06:10 PM, Jason Ekstrand wrote:
On Mon, Jul 9, 2018 at 8:29 AM Samuel Pitoiset
mailto:samuel.pitoi...@gmail.com>> wrote:
On 07/09/2018 05:28 PM, Jason Ekstrand wrote:
> Are there any tests for this anywhere?
Unfortunately, not yet.
Someone should write some then
On Mon, Jul 9, 2018 at 8:29 AM Samuel Pitoiset
wrote:
>
> On 07/09/2018 05:28 PM, Jason Ekstrand wrote:
> > Are there any tests for this anywhere?
>
> Unfortunately, not yet.
>
Someone should write some then. :-) I recently wrote tests for
VK_EXT_vertex_attribute_divisor and we discovered that
On 07/09/2018 05:28 PM, Jason Ekstrand wrote:
Are there any tests for this anywhere?
Unfortunately, not yet.
On Mon, Jul 9, 2018 at 5:56 AM Samuel Pitoiset
mailto:samuel.pitoi...@gmail.com>> wrote:
Inherited commands buffers are not supported.
v2: - disable predication for blit
Are there any tests for this anywhere?
On Mon, Jul 9, 2018 at 5:56 AM Samuel Pitoiset
wrote:
> Inherited commands buffers are not supported.
>
> v2: - disable predication for blit and copy commands
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 29 ++
Inherited commands buffers are not supported.
v2: - disable predication for blit and copy commands
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 29 +
src/amd/vulkan/radv_device.c | 7 +++
src/amd/vulkan/radv_extensions.py | 1 +
s
