Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-10-03 Thread Emil Velikov
On Wed, 3 Oct 2018 at 09:19, Mathias Fröhlich wrote: > > Hi Emil, > > On Tuesday, 2 October 2018 11:59:23 CEST Emil Velikov wrote: > > > > + return dev->device->nodes[DRM_NODE_PRIMARY]; > > > ... we probably want > > > return _eglGetDRMDeviceRenderNode(dev); > > > > > That isn't quite poss

Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-10-03 Thread Mathias Fröhlich
Hi Emil, On Tuesday, 2 October 2018 11:59:23 CEST Emil Velikov wrote: > > > + return dev->device->nodes[DRM_NODE_PRIMARY]; > > ... we probably want > > return _eglGetDRMDeviceRenderNode(dev); > > > That isn't quite possible, as discussed in 2016's thread > "EGL_EXT_*_drm - primary vs rende

Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-10-02 Thread Emil Velikov
Hi Mathias, On Thu, 20 Sep 2018 at 15:12, Mathias Fröhlich wrote: > > @@ -141,6 +231,12 @@ _eglQueryDeviceStringEXT(_EGLDevice *dev, EGLint name) > > switch (name) { > > case EGL_EXTENSIONS: > >return dev->extensions; > > +#ifdef HAVE_LIBDRM > > + case EGL_DRM_DEVICE_FILE_EXT:

Re: [Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-09-20 Thread Mathias Fröhlich
Hi Emil, There are some comments inline below: On Tuesday, 4 September 2018 20:33:00 CEST Emil Velikov wrote: > From: Emil Velikov > > Add implementation based around the drmDevice API. As such it's only > available only when building with libdrm. With the latter already a > requirement when us

[Mesa-dev] [PATCH v2 3/8] egl: add EGL_EXT_device_drm support

2018-09-04 Thread Emil Velikov
From: Emil Velikov Add implementation based around the drmDevice API. As such it's only available only when building with libdrm. With the latter already a requirement when using !SW code paths in the platform code. Note: the current code will work if a device is hot-plugged. Yet hot-unplugged i