Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

2017-12-11 Thread Ian Romanick
On 12/04/2017 12:12 PM, Antia Puentes wrote: > The new order is: > * VE 1: > * VE 2: > > Previously it was: > * VE 1: > * VE 2: > > The gl_BaseVertex is in a new location now, and firstvertex occupies > the old gl_BaseVertex place. This way we can keep pointing to the > indirect buffer for in

Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

2017-12-11 Thread Kenneth Graunke
On Tuesday, December 5, 2017 3:23:03 PM PST Kenneth Graunke wrote: > Reviewed-by: Kenneth Graunke It turns out that patches 1-3 by themselves cause piles of Piglit and CTS failures. Please make sure the series doesn't cause regressions at each step along the way. For reference, here are some of

Re: [Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

2017-12-05 Thread Kenneth Graunke
On Monday, December 4, 2017 12:12:49 PM PST Antia Puentes wrote: > The new order is: > * VE 1: > * VE 2: > > Previously it was: > * VE 1: > * VE 2: > > The gl_BaseVertex is in a new location now, and firstvertex occupies > the old gl_BaseVertex place. This way we can keep pointing to the > in

[Mesa-dev] [PATCH v2 3/7] intel: emit first_vertex and reorder the VE' components

2017-12-04 Thread Antia Puentes
The new order is: * VE 1: * VE 2: Previously it was: * VE 1: * VE 2: The gl_BaseVertex is in a new location now, and firstvertex occupies the old gl_BaseVertex place. This way we can keep pointing to the indirect buffer for indirect draw calls. Reviewed-by: Neil Roberts --- src/intel/compi