On 01/19/2018 20:38, Emil Velikov wrote:
On 18 January 2018 at 22:54, Greg V wrote:
Move the Weston os_create_anonymous_file code from egl/wayland into util,
add support for Linux memfd and FreeBSD SHM_ANON,
use that code in anv instead of explicit memfd calls for portability.
---
Looks quite
On 01/24/2018 15:16, Emil Velikov wrote:
On 24 January 2018 at 11:58, Greg V wrote:
+#ifndef __FreeBSD__
mkstemp does exist on FreeBSD, right? If so you can drop this guard
and simplify the one in os_create_anonymous_file().
The guard is there because this function (create_tmpfile_cloexec)
On 24 January 2018 at 11:58, Greg V wrote:
>>>
>>> +#ifndef __FreeBSD__
>>
>> mkstemp does exist on FreeBSD, right? If so you can drop this guard
>> and simplify the one in os_create_anonymous_file().
>
> The guard is there because this function (create_tmpfile_cloexec) goes
> unused on FreeBSD.
On 18 January 2018 at 22:54, Greg V wrote:
> Move the Weston os_create_anonymous_file code from egl/wayland into util,
> add support for Linux memfd and FreeBSD SHM_ANON,
> use that code in anv instead of explicit memfd calls for portability.
> ---
Looks quite good - a few small suggestions below
Move the Weston os_create_anonymous_file code from egl/wayland into util,
add support for Linux memfd and FreeBSD SHM_ANON,
use that code in anv instead of explicit memfd calls for portability.
---
src/egl/drivers/dri2/platform_wayland.c | 116 +-
src/intel/vulkan/anv_allocator
