Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-04 Thread Connor Abbott
On Mon, Aug 4, 2014 at 10:42 AM, Connor Abbott wrote: > On Mon, Aug 4, 2014 at 10:17 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: Connor Abbott writes: > On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: >> Conno

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-04 Thread Connor Abbott
On Mon, Aug 4, 2014 at 10:17 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: >>> Connor Abbott writes: >>> On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Fri, Aug 1, 2014 at 11:51 AM,

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-04 Thread Eric Anholt
Connor Abbott writes: > On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: Connor Abbott writes: > On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-04 Thread Connor Abbott
On Mon, Aug 4, 2014 at 9:46 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: >>> Connor Abbott writes: >>> On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Thu, Jul 31, 2014 at 1:05 PM,

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-04 Thread Eric Anholt
Connor Abbott writes: > On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: Connor Abbott writes: > On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: >> Connor Abbott writes: >>> That

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-01 Thread Kenneth Graunke
On Wednesday, July 30, 2014 10:50:59 PM Eric Anholt wrote: > Connor Abbott writes: > > > Before, we would only consider nodes for spilling if they were > > optimistically pushed onto the stack. But the logic for this was > > complicated, and duplicated some things; also, we might want to spill >

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-01 Thread Connor Abbott
On Fri, Aug 1, 2014 at 12:25 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: >>> Connor Abbott writes: >>> On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: > Connor Abbott writes: >> That's not necessarily true - you coul

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-01 Thread Eric Anholt
Connor Abbott writes: > On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: >> Connor Abbott writes: >> >>> On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: Connor Abbott writes: > That's not necessarily true - you could want to spill a trivially > colored register that interf

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-01 Thread Connor Abbott
On Fri, Aug 1, 2014 at 11:51 AM, Eric Anholt wrote: > Connor Abbott writes: > >> On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: >>> Connor Abbott writes: That's not necessarily true - you could want to spill a trivially colored register that interferes with a non trivially colore

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-08-01 Thread Eric Anholt
Connor Abbott writes: > On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: >> Connor Abbott writes: >>> That's not necessarily true - you could want to spill a trivially >>> colored register that interferes with a non trivially colored >>> register, especially if the spill cost of the non triv

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-31 Thread Connor Abbott
On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: > Connor Abbott writes: >> That's not necessarily true - you could want to spill a trivially >> colored register that interferes with a non trivially colored >> register, especially if the spill cost of the non trivially colored >> register is h

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-31 Thread Eric Anholt
Connor Abbott writes: > That's not necessarily true - you could want to spill a trivially > colored register that interferes with a non trivially colored > register, especially if the spill cost of the non trivially colored > register is higher than that of the trivially colored register because >

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-31 Thread Connor Abbott
On Wed, Jul 30, 2014 at 10:50 PM, Eric Anholt wrote: > Connor Abbott writes: > >> Before, we would only consider nodes for spilling if they were >> optimistically pushed onto the stack. But the logic for this was >> complicated, and duplicated some things; also, we might want to spill >> nodes th

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-30 Thread Eric Anholt
Connor Abbott writes: > Before, we would only consider nodes for spilling if they were > optimistically pushed onto the stack. But the logic for this was > complicated, and duplicated some things; also, we might want to spill > nodes that are not optimistically colored if our heuristic says we >

[Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-30 Thread Connor Abbott
Before, we would only consider nodes for spilling if they were optimistically pushed onto the stack. But the logic for this was complicated, and duplicated some things; also, we might want to spill nodes that are not optimistically colored if our heuristic says we should. This becomes a problem esp