Re: [Mesa-dev] [PATCH v2 3/3] imx: gallium driver for imx-drm scanout driver

2017-01-12 Thread Christian Gmeiner
Hi Emil, thanks for your review! 2017-01-10 14:22 GMT+01:00 Emil Velikov : > Hi Christian, > > Similar to 2/3 there's a few trivial nitpicks which can be addressed > at a later stage. > I fixed them and will squash them. > On 23 December 2016 at 22:04, Christian Gmeiner > wrote: >> Changes fro

Re: [Mesa-dev] [PATCH v2 3/3] imx: gallium driver for imx-drm scanout driver

2017-01-10 Thread Emil Velikov
Hi Christian, Similar to 2/3 there's a few trivial nitpicks which can be addressed at a later stage. On 23 December 2016 at 22:04, Christian Gmeiner wrote: > Changes from V1 -> V2: > - updated Copyright > - added $(top_srcdir)/src/gallium/winsys to include path (suggested by Emil) > - adapted

Re: [Mesa-dev] [PATCH v2 3/3] imx: gallium driver for imx-drm scanout driver

2017-01-10 Thread Emil Velikov
On 4 January 2017 at 09:10, Thierry Reding wrote: > On Fri, Dec 23, 2016 at 11:04:51PM +0100, Christian Gmeiner wrote: > [...] >> +struct pipe_screen *imx_drm_screen_create(int fd) >> +{ >> + struct renderonly ro = { >> + .create_for_resource = renderonly_create_kms_dumb_buffer_for_resource

Re: [Mesa-dev] [PATCH v2 3/3] imx: gallium driver for imx-drm scanout driver

2017-01-04 Thread Thierry Reding
On Fri, Dec 23, 2016 at 11:04:51PM +0100, Christian Gmeiner wrote: [...] > +struct pipe_screen *imx_drm_screen_create(int fd) > +{ > + struct renderonly ro = { > + .create_for_resource = renderonly_create_kms_dumb_buffer_for_resource, > + .kms_fd = fd, > + .gpu_fd = open("/dev/dri/

[Mesa-dev] [PATCH v2 3/3] imx: gallium driver for imx-drm scanout driver

2016-12-23 Thread Christian Gmeiner
Changes from V1 -> V2: - updated Copyright - added $(top_srcdir)/src/gallium/winsys to include path (suggested by Emil) - adapted driver to new renderonly API Signed-off-by: Christian Gmeiner --- configure.ac | 12 ++ src/gallium/Makefile.am