Re: [Mesa-dev] [PATCH v2 23/36] isl: Remove duplicate px->sa conversions

2016-07-19 Thread Nanley Chery
On Tue, Jul 19, 2016 at 04:16:23PM -0700, Jason Ekstrand wrote: > On Tue, Jul 19, 2016 at 4:12 PM, Nanley Chery wrote: > > > On Fri, Jul 01, 2016 at 04:08:49PM -0700, Jason Ekstrand wrote: > > > In all three cases, we start with width and height taken from > > > isl_surf::phys_slice0_extent_sa wh

Re: [Mesa-dev] [PATCH v2 23/36] isl: Remove duplicate px->sa conversions

2016-07-19 Thread Nanley Chery
On Tue, Jul 19, 2016 at 04:12:17PM -0700, Nanley Chery wrote: > On Fri, Jul 01, 2016 at 04:08:49PM -0700, Jason Ekstrand wrote: > > In all three cases, we start with width and height taken from > > isl_surf::phys_slice0_extent_sa which is already in samples. There is no > > need to do the conversi

Re: [Mesa-dev] [PATCH v2 23/36] isl: Remove duplicate px->sa conversions

2016-07-19 Thread Jason Ekstrand
On Tue, Jul 19, 2016 at 4:12 PM, Nanley Chery wrote: > On Fri, Jul 01, 2016 at 04:08:49PM -0700, Jason Ekstrand wrote: > > In all three cases, we start with width and height taken from > > isl_surf::phys_slice0_extent_sa which is already in samples. There is no > > need to do the conversion and

Re: [Mesa-dev] [PATCH v2 23/36] isl: Remove duplicate px->sa conversions

2016-07-19 Thread Nanley Chery
On Fri, Jul 01, 2016 at 04:08:49PM -0700, Jason Ekstrand wrote: > In all three cases, we start with width and height taken from > isl_surf::phys_slice0_extent_sa which is already in samples. There is no > need to do the conversion and doing so gives us an incorrect value. Thanks for noticing this

[Mesa-dev] [PATCH v2 23/36] isl: Remove duplicate px->sa conversions

2016-07-01 Thread Jason Ekstrand
In all three cases, we start with width and height taken from isl_surf::phys_slice0_extent_sa which is already in samples. There is no need to do the conversion and doing so gives us an incorrect value. --- src/intel/isl/isl.c | 20 1 file changed, 20 deletions(-) diff --git