Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

2017-06-20 Thread Lin, Johnson
Thanks for the comments. I don't have a swap in other places in the patches. But I think your point is good, from the code that is a swap of U/V channels. I am suspecting there might be some bug somewhere else. Need to continue to investigate. -Original Message- From: hoegsb...@gmail.co

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

2017-06-20 Thread Kristian Høgsberg
On Mon, Jun 19, 2017 at 7:07 PM, Lin, Johnson wrote: > Kristian, > > Thanks for the review comments. By my tests, UYVY buffer can be sampled and > rendered correctly. So there is no swap of U/V channel here. Just saying "the test pass, all is fine" isn't good enough. See below. > > -Origina

Re: [Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

2017-06-19 Thread Lin, Johnson
Kristian, Thanks for the review comments. By my tests, UYVY buffer can be sampled and rendered correctly. So there is no swap of U/V channel here. -Original Message- From: Lin, Johnson Sent: Tuesday, June 20, 2017 9:43 AM To: mesa-dev@lists.freedesktop.org Cc: Lin, Johnson Subject: [P

[Mesa-dev] [PATCH v2 2/3] nir: Add a lowering pass for UYVY textures

2017-06-19 Thread Johnson Lin
Similar with support for YUYV but with byte order difference in sampler --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_tex.c | 16 2 files changed, 17 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index ab7ba14303b7..1b4e47058