Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 2:10 PM, Rob Clark wrote: > On Sat, Aug 8, 2015 at 4:26 PM, Jason Ekstrand wrote: >> On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay wrote: >>> On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: > On Sat, Aug 8,

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Rob Clark
On Sat, Aug 8, 2015 at 4:26 PM, Jason Ekstrand wrote: > On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay wrote: >> On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: >>> On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: > On

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Jason Ekstrand
On Sat, Aug 8, 2015 at 1:01 PM, Oded Gabbay wrote: > On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: >> On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: >>> On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: > This patch

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Oded Gabbay
On Sat, Aug 8, 2015 at 7:34 PM, Jason Ekstrand wrote: > On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: >> On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: >>> On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: This patch fixes a bug that is manifested in the read path of mesa wh

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-08 Thread Jason Ekstrand
On Fri, Aug 7, 2015 at 10:38 PM, Oded Gabbay wrote: > On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: >> On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >>> This patch fixes a bug that is manifested in the read path of mesa when >>> running on big-endian machines. The effects can be se

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Oded Gabbay
On Sat, Aug 8, 2015 at 8:38 AM, Oded Gabbay wrote: > On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: >> On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >>> This patch fixes a bug that is manifested in the read path of mesa when >>> running on big-endian machines. The effects can be see

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Oded Gabbay
On Sat, Aug 8, 2015 at 3:11 AM, Jason Ekstrand wrote: > On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >> This patch fixes a bug that is manifested in the read path of mesa when >> running on big-endian machines. The effects can be seen when running >> piglit sanity test and/or taking a scre

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Ilia Mirkin
On Sat, Aug 8, 2015 at 12:08 AM, Rob Clark wrote: > > On Fri, Aug 7, 2015 at 8:11 PM, Jason Ekstrand wrote: > > On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: > >> This patch fixes a bug that is manifested in the read path of mesa when > >> running on big-endian machines. The effects can be

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Jason Ekstrand
On Aug 7, 2015 21:08, "Rob Clark" wrote: > > On Fri, Aug 7, 2015 at 8:11 PM, Jason Ekstrand wrote: > > On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: > >> This patch fixes a bug that is manifested in the read path of mesa when > >> running on big-endian machines. The effects can be seen whe

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Rob Clark
On Fri, Aug 7, 2015 at 8:11 PM, Jason Ekstrand wrote: > On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >> This patch fixes a bug that is manifested in the read path of mesa when >> running on big-endian machines. The effects can be seen when running >> piglit sanity test and/or taking a scre

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Jason Ekstrand
On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: > This patch fixes a bug that is manifested in the read path of mesa when > running on big-endian machines. The effects can be seen when running > piglit sanity test and/or taking a screen capture. piglit sanity isn't all that convincing. It's

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Oded Gabbay
On Fri, Aug 7, 2015 at 10:37 PM, Oded Gabbay wrote: > On Fri, Aug 7, 2015 at 10:30 PM, Matt Turner wrote: >> On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >>> This patch fixes a bug that is manifested in the read path of mesa when >>> running on big-endian machines. The effects can be seen

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Oded Gabbay
On Fri, Aug 7, 2015 at 10:30 PM, Matt Turner wrote: > On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: >> This patch fixes a bug that is manifested in the read path of mesa when >> running on big-endian machines. The effects can be seen when running >> piglit sanity test and/or taking a screen

Re: [Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Matt Turner
On Fri, Aug 7, 2015 at 12:24 PM, Oded Gabbay wrote: > This patch fixes a bug that is manifested in the read path of mesa when > running on big-endian machines. The effects can be seen when running > piglit sanity test and/or taking a screen capture. > > The bug is caused when _mesa_format_convert

[Mesa-dev] [PATCH v2 2/2] mesa: _mesa_format_convert should be endian agnostic

2015-08-07 Thread Oded Gabbay
This patch fixes a bug that is manifested in the read path of mesa when running on big-endian machines. The effects can be seen when running piglit sanity test and/or taking a screen capture. The bug is caused when _mesa_format_convert receives src_format as mesa_format, which it thens changes to