Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-18 Thread Alejandro Piñeiro
On 18/04/16 16:11, Alejandro Piñeiro wrote: > On 18/04/16 00:47, Ilia Mirkin wrote: >> On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro >> wrote: >>> v2: >>> * Take into account out varyings too (Timothy Arceri) >>> * Fix style (Timothy Arceri) >>> * Use a new ast_expression variable, inst

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-18 Thread Alejandro Piñeiro
On 18/04/16 00:47, Ilia Mirkin wrote: > On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro > wrote: >> v2: >> * Take into account out varyings too (Timothy Arceri) >> * Fix style (Timothy Arceri) >> * Use a new ast_expression variable, instead of an >>ast_expression::hir new parameter (Tim

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-17 Thread Alejandro Piñeiro
I will take a look to this one today. Thanks for pointing it On 18/04/16 00:47, Ilia Mirkin wrote: > On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro > wrote: >> v2: >> * Take into account out varyings too (Timothy Arceri) >> * Fix style (Timothy Arceri) >> * Use a new ast_expression varia

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-04-17 Thread Ilia Mirkin
On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro wrote: > v2: > * Take into account out varyings too (Timothy Arceri) > * Fix style (Timothy Arceri) > * Use a new ast_expression variable, instead of an >ast_expression::hir new parameter (Timothy Arceri) > > Bugzilla: https://bugs.freedesk

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-31 Thread Kenneth Graunke
On Thursday, March 31, 2016 12:37:31 AM PDT Jordan Justen wrote: > On 2016-03-30 02:03:29, Alejandro Piñeiro wrote: > > On 30/03/16 09:44, Alejandro Piñeiro wrote: > > > On 30/03/16 06:16, Kenneth Graunke wrote: > > > > >> I was just looking at that today...adding an ordinary global variable > > >

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-31 Thread Ilia Mirkin
On Thu, Mar 31, 2016 at 5:07 AM, Alejandro Piñeiro wrote: > On 31/03/16 09:37, Jordan Justen wrote: >> On 2016-03-30 02:03:29, Alejandro Piñeiro wrote: >>> On 30/03/16 09:44, Alejandro Piñeiro wrote: On 30/03/16 06:16, Kenneth Graunke wrote: > I was just looking at that today...adding an

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-31 Thread Alejandro Piñeiro
On 31/03/16 09:37, Jordan Justen wrote: > On 2016-03-30 02:03:29, Alejandro Piñeiro wrote: >> On 30/03/16 09:44, Alejandro Piñeiro wrote: >>> On 30/03/16 06:16, Kenneth Graunke wrote: I was just looking at that today...adding an ordinary global variable in builtin_variables.cpp seems real

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-31 Thread Jordan Justen
On 2016-03-30 02:03:29, Alejandro Piñeiro wrote: > On 30/03/16 09:44, Alejandro Piñeiro wrote: > > On 30/03/16 06:16, Kenneth Graunke wrote: > > >> I was just looking at that today...adding an ordinary global variable > >> in builtin_variables.cpp seems really wrong. > > I think that I don't follo

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-30 Thread Alejandro Piñeiro
On 30/03/16 09:44, Alejandro Piñeiro wrote: > On 30/03/16 06:16, Kenneth Graunke wrote: >> On Tuesday, March 29, 2016 5:09:37 PM PDT Ilia Mirkin wrote: >>> This is triggering for gl_GlobalInvocationID :( > :( > >>> I think it's because >>> of how the variable is computed -- a lowering pass after

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-30 Thread Alejandro Piñeiro
On 30/03/16 06:16, Kenneth Graunke wrote: > On Tuesday, March 29, 2016 5:09:37 PM PDT Ilia Mirkin wrote: >> This is triggering for gl_GlobalInvocationID :( :( >> I think it's because >> of how the variable is computed -- a lowering pass after compilation >> is added to initialize it IIRC. Perhap

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-29 Thread Kenneth Graunke
On Tuesday, March 29, 2016 5:09:37 PM PDT Ilia Mirkin wrote: > This is triggering for gl_GlobalInvocationID :( I think it's because > of how the variable is computed -- a lowering pass after compilation > is added to initialize it IIRC. Perhaps this should try to ignore > global variables? I was j

Re: [Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-29 Thread Ilia Mirkin
This is triggering for gl_GlobalInvocationID :( I think it's because of how the variable is computed -- a lowering pass after compilation is added to initialize it IIRC. Perhaps this should try to ignore global variables? On Mon, Mar 28, 2016 at 2:50 PM, Alejandro Piñeiro wrote: > v2: > * Take i

[Mesa-dev] [PATCH v2 2/2] glsl: raise warning when using uninitialized variables

2016-03-28 Thread Alejandro Piñeiro
v2: * Take into account out varyings too (Timothy Arceri) * Fix style (Timothy Arceri) * Use a new ast_expression variable, instead of an ast_expression::hir new parameter (Timothy Arceri) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94129 --- src/compiler/glsl/ast_to_hir.cpp | 7