Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-20 Thread Emil Velikov
On Tue, 18 Dec 2018 at 14:23, Kyle Brenneman wrote: > On 12/14/2018 07:04 AM, Emil Velikov wrote: > > -print(generate_public_stubs(functions)) > > +if target in "gldispatch": > This should be an "==", not "in". The in operator would do a substring > search. Thanks Kyle, fixed locally. If

Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-18 Thread Kyle Brenneman
On 12/14/2018 07:04 AM, Emil Velikov wrote: There is no need for the noop functions, the public_stubs and public_entries table or table size defines. Remove those. Pretty much all of this is applicable to GLVND, although it requires preparatory work. v2: - python style fixes (Dylan) - use "

Re: [Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-14 Thread Erik Faye-Lund
Reviewed-by: Erik Faye-Lund On Fri, 2018-12-14 at 14:04 +, Emil Velikov wrote: > There is no need for the noop functions, the public_stubs and > public_entries table or table size defines. Remove those. > > Pretty much all of this is applicable to GLVND, although it > requires preparatory wo

[Mesa-dev] [PATCH v2 13/24] mapi/new: don't print info we don't need for ES1/ES2

2018-12-14 Thread Emil Velikov
There is no need for the noop functions, the public_stubs and public_entries table or table size defines. Remove those. Pretty much all of this is applicable to GLVND, although it requires preparatory work. v2: - python style fixes (Dylan) - use "gldispatch" instead of not "glesv1" "glesv2" -