Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-24 Thread Kenneth Graunke
On Friday, June 20, 2014 08:51:14 AM Iago Toral wrote: > On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: > > On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: > (...) > > > + /* From the ARB_gpu_shader5 spec: > > > + * > > > + * "Multiple vertex streams are supported only

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-19 Thread Iago Toral
On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: > On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: (...) > > + /* From the ARB_gpu_shader5 spec: > > + * > > + * "Multiple vertex streams are supported only if the output > > primitive > > + *type is declared to b

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-18 Thread Iago Toral
On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: > On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: > > Check if non-zero streams are used. Fail to link if emitting to unsupported > > streams or emitting to non-zero streams with output type other than > > GL_POINTS. > > --- > > src/glsl/li

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-18 Thread Ian Romanick
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: > Check if non-zero streams are used. Fail to link if emitting to unsupported > streams or emitting to non-zero streams with output type other than GL_POINTS. > --- > src/glsl/linker.cpp | 148 > +++-

[Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-18 Thread Iago Toral Quiroga
Check if non-zero streams are used. Fail to link if emitting to unsupported streams or emitting to non-zero streams with output type other than GL_POINTS. --- src/glsl/linker.cpp | 148 +++- 1 file changed, 134 insertions(+), 14 deletions(-) diff --