Re: [Mesa-dev] [PATCH v2 118.5/133] nir/tex_instr_create: Initialize all 4 sources

2015-01-09 Thread Connor Abbott
On Fri, Jan 9, 2015 at 5:41 PM, Jason Ekstrand wrote: > > > On Fri, Jan 9, 2015 at 11:34 AM, Connor Abbott wrote: >> >> BTW, now that we're adding an extra possible source, do we need to >> expand the size of the source array? > > > I don't know that we've added anything that wasn't there before.

Re: [Mesa-dev] [PATCH v2 118.5/133] nir/tex_instr_create: Initialize all 4 sources

2015-01-09 Thread Jason Ekstrand
On Fri, Jan 9, 2015 at 11:34 AM, Connor Abbott wrote: > BTW, now that we're adding an extra possible source, do we need to > expand the size of the source array? > I don't know that we've added anything that wasn't there before. Then again, it's not documented how you came to the number 4. Als

Re: [Mesa-dev] [PATCH v2 118.5/133] nir/tex_instr_create: Initialize all 4 sources

2015-01-09 Thread Connor Abbott
BTW, now that we're adding an extra possible source, do we need to expand the size of the source array? Anyways, Reviewed-by: Connor Abbott On Wed, Jan 7, 2015 at 9:03 PM, Jason Ekstrand wrote: > This helps a lot with things like lowering passes that may need to add > sources. > --- > src/glsl

[Mesa-dev] [PATCH v2 118.5/133] nir/tex_instr_create: Initialize all 4 sources

2015-01-07 Thread Jason Ekstrand
This helps a lot with things like lowering passes that may need to add sources. --- src/glsl/nir/nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 9b99c9e..c8d354d 100644 --- a/src/glsl/nir/nir.c +++ b/src/glsl/nir/nir.c @@ -458