Re: [Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-20 Thread Jordan Justen
On 2017-10-18 22:31:59, Jordan Justen wrote: > From: Connor Abbott > > diff --git a/src/compiler/nir/nir_serialize.c > b/src/compiler/nir/nir_serialize.c > new file mode 100644 > index 00..fb6232446b > --- /dev/null > +++ b/src/compiler/nir/nir_serialize.c > +static void > +read_instr(r

Re: [Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-20 Thread Jason Ekstrand
I left a few notes but have *not* reviewed this. I would feel much more comfortable landing it someone went through and verified two things by hand: 1) We actually fill out all of the data structure fields (clearly things like uses and defs are filled our by core NIR automatically) 2) We get th

Re: [Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-19 Thread Timothy Arceri
Acked-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v2 11/32] nir: add serialization and deserialization

2017-10-18 Thread Jordan Justen
From: Connor Abbott v2 (Jason Ekstrand): - Various whitespace cleanups - Add helpers for reading/writing objects - Rework derefs - [de]serialize nir_shader::num_* - Fix uses of blob_reserve_bytes - Use a bitfield struct for packing tex_instr data v3: - Zero nir_variable struct on deserial