Re: [Mesa-dev] [PATCH v2 1/4] dri/image: Add a format modifier attributes query

2017-09-07 Thread Emil Velikov
On 5 September 2017 at 19:29, Jason Ekstrand wrote: > On Tue, Sep 5, 2017 at 10:14 AM, Emil Velikov > wrote: >> >> Hi Jason, >> >> On 5 September 2017 at 16:48, Jason Ekstrand wrote: >> >> > + GLboolean (*queryDmaBufFormatModifierAttribs)(__DRIscreen *screen, >> > +

Re: [Mesa-dev] [PATCH v2 1/4] dri/image: Add a format modifier attributes query

2017-09-05 Thread Jason Ekstrand
On Tue, Sep 5, 2017 at 10:14 AM, Emil Velikov wrote: > Hi Jason, > > On 5 September 2017 at 16:48, Jason Ekstrand wrote: > > > + GLboolean (*queryDmaBufFormatModifierAttribs)(__DRIscreen *screen, > > + uint32_t fourcc, > We seems to be using "int

Re: [Mesa-dev] [PATCH v2 1/4] dri/image: Add a format modifier attributes query

2017-09-05 Thread Emil Velikov
Hi Jason, On 5 September 2017 at 16:48, Jason Ekstrand wrote: > + GLboolean (*queryDmaBufFormatModifierAttribs)(__DRIscreen *screen, > + uint32_t fourcc, We seems to be using "int fourcc" throughout the file. Worth saying consistent and doing the

[Mesa-dev] [PATCH v2 1/4] dri/image: Add a format modifier attributes query

2017-09-05 Thread Jason Ekstrand
--- include/GL/internal/dri_interface.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 1c91bde..783ff1c 100644 --- a/include/GL/internal/dri_interface.h +++ b/include/G