Re: [Mesa-dev] [PATCH v2 1/2] r600g: make condition clearer

2017-03-20 Thread Dieter Nützel
Am 20.03.2017 13:43, schrieb Constantine Kharlamov: Aah, I see… Should I resend again? Mhhhmmm, I think it should be smarter for the committer and I do not have that right ;-) Marek your turn? Who is the 'man' for older cards? On 20.03.2017 15:40, Dieter Nützel wrote: Constantine, you mis

Re: [Mesa-dev] [PATCH v2 1/2] r600g: make condition clearer

2017-03-20 Thread Constantine Kharlamov
Aah, I see… Should I resend again? On 20.03.2017 15:40, Dieter Nützel wrote: > Constantine, > you missed my > > 1/1 > Tested-by: Dieter Nützel > 1/2 > Acked-by: Dieter Nützel > > they should be appended under your Signed-off-by during resend/rebase. > > Anyway, looks good. > Dieter > > PS ..

Re: [Mesa-dev] [PATCH v2 1/2] r600g: make condition clearer

2017-03-20 Thread Dieter Nützel
Constantine, you missed my 1/1 Tested-by: Dieter Nützel 1/2 Acked-by: Dieter Nützel they should be appended under your Signed-off-by during resend/rebase. Anyway, looks good. Dieter PS ...Dieter's comment... is enough ;-) Am 20.03.2017 13:19, schrieb Constantine Kharlamov: The second check

[Mesa-dev] [PATCH v2 1/2] r600g: make condition clearer

2017-03-20 Thread Constantine Kharlamov
The second check in the old code looked pretty much unreachable, esp. because it's not obvious that "max_entries" could be zero. To find out that it was intentional I had to run some checks, and to dig into the old versions of the file. So, rewrite the check to make the intention clear. v2: s/r60