Re: [Mesa-dev] [PATCH v2 1/2] isl: introduce depth pitch query function

2016-12-09 Thread Jason Ekstrand
On Fri, Dec 9, 2016 at 8:45 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 08/12/16 19:19, Jason Ekstrand wrote: > > On Dec 8, 2016 8:48 AM, "Lionel Landwerlin" wrote: > > v2: add lod level argument (Jason) > return 0 for any lod level > 0 (Jason) > return 0 for any su

Re: [Mesa-dev] [PATCH v2 1/2] isl: introduce depth pitch query function

2016-12-09 Thread Lionel Landwerlin
On 08/12/16 19:19, Jason Ekstrand wrote: On Dec 8, 2016 8:48 AM, "Lionel Landwerlin" > wrote: v2: add lod level argument (Jason) return 0 for any lod level > 0 (Jason) return 0 for any surface not 3D (Jason) I'd rather have ISL assert these tha

Re: [Mesa-dev] [PATCH v2 1/2] isl: introduce depth pitch query function

2016-12-08 Thread Jason Ekstrand
On Dec 8, 2016 8:48 AM, "Lionel Landwerlin" wrote: v2: add lod level argument (Jason) return 0 for any lod level > 0 (Jason) return 0 for any surface not 3D (Jason) I'd rather have ISL assert these than just silently return 0. That way it's clear they make no sense. We can have a dime

[Mesa-dev] [PATCH v2 1/2] isl: introduce depth pitch query function

2016-12-08 Thread Lionel Landwerlin
v2: add lod level argument (Jason) return 0 for any lod level > 0 (Jason) return 0 for any surface not 3D (Jason) Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.isl.am | 10 +- src/intel/isl/isl.c| 28 +++ src/intel/isl/