Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-31 Thread Marek Olšák
It looks good to me. Marek On Tue, Mar 31, 2015 at 9:39 AM, Samuel Pitoiset wrote: > > > On 03/30/2015 11:17 PM, Marek Olšák wrote: >> >> You can add a flag to each driver query identifying what kind of query >> it is (a hw perf counter or a CPU-only query). Then you can enumerate >> all queries

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-31 Thread Samuel Pitoiset
On 03/30/2015 11:17 PM, Marek Olšák wrote: You can add a flag to each driver query identifying what kind of query it is (a hw perf counter or a CPU-only query). Then you can enumerate all queries and see if there's at least one perf counter and if so, advertise the extension. Or add a CAP and

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-30 Thread Marek Olšák
You can add a flag to each driver query identifying what kind of query it is (a hw perf counter or a CPU-only query). Then you can enumerate all queries and see if there's at least one perf counter and if so, advertise the extension. Or add a CAP and let drivers decide if they want the extension o

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-30 Thread Samuel Pitoiset
On 03/29/2015 06:11 PM, Martin Peres wrote: On 29/03/2015 17:56, Samuel Pitoiset wrote: On 03/28/2015 09:43 PM, Martin Peres wrote: On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freede

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-29 Thread Martin Peres
On 29/03/2015 17:56, Samuel Pitoiset wrote: On 03/28/2015 09:43 PM, Martin Peres wrote: On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) It would be

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-29 Thread Martin Peres
On 29/03/2015 17:57, Samuel Pitoiset wrote: On 03/29/2015 11:13 AM, Martin Peres wrote: On 29/03/2015 04:02, Marek Olšák wrote: On Sat, Mar 28, 2015 at 9:43 PM, Martin Peres wrote: On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-29 Thread Samuel Pitoiset
On 03/29/2015 11:13 AM, Martin Peres wrote: On 29/03/2015 04:02, Marek Olšák wrote: On Sat, Mar 28, 2015 at 9:43 PM, Martin Peres wrote: On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.f

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-29 Thread Samuel Pitoiset
On 03/28/2015 09:43 PM, Martin Peres wrote: On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) It would be nice if you could add "v2: Samuel Pitoiset"

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-29 Thread Martin Peres
On 29/03/2015 04:02, Marek Olšák wrote: On Sat, Mar 28, 2015 at 9:43 PM, Martin Peres wrote: On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) It wou

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-28 Thread Marek Olšák
On Sat, Mar 28, 2015 at 9:43 PM, Martin Peres wrote: > On 22/03/2015 17:35, Samuel Pitoiset wrote: >> >> From: Christoph Bumiller >> >> This is based on the original patch of Christoph Bumiller. >> (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) > > > It would be nice if you could

Re: [Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-28 Thread Martin Peres
On 22/03/2015 17:35, Samuel Pitoiset wrote: From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) It would be nice if you could add "v2: Samuel Pitoiset" and tell what you changed. Christoph may dele

[Mesa-dev] [PATCH v2 06/15] st/mesa: implement GL_AMD_performance_monitor

2015-03-22 Thread Samuel Pitoiset
From: Christoph Bumiller This is based on the original patch of Christoph Bumiller. (source: http://people.freedesktop.org/~chrisbmr/perfmon.diff) As for the Gallium HUD, we keep a list of busy queries in a ring buffer in order to prevent stalls when reading queries. Drivers must implement get_