Re: [Mesa-dev] [PATCH v2 05/25] mesa: implement SPIR-V loading in glShaderBinary

2017-12-13 Thread Jon Turney
On 30/11/2017 23:57, Ian Romanick wrote: On 11/30/2017 09:28 AM, Eduardo Lima Mitev wrote: From: Nicolai Hähnle v2: * Add a gl_shader_spirv_data member to gl_shader, which already encapsulates a gl_spirv_module where the binary will be saved. (Eduardo Lima) * Just use the 'spirv_

Re: [Mesa-dev] [PATCH v2 05/25] mesa: implement SPIR-V loading in glShaderBinary

2017-11-30 Thread Ian Romanick
Two nits below... On 11/30/2017 09:28 AM, Eduardo Lima Mitev wrote: > From: Nicolai Hähnle > > v2: * Add a gl_shader_spirv_data member to gl_shader, which already >encapsulates a gl_spirv_module where the binary will be saved. >(Eduardo Lima) > > * Just use the 'spirv_data' member t

[Mesa-dev] [PATCH v2 05/25] mesa: implement SPIR-V loading in glShaderBinary

2017-11-30 Thread Eduardo Lima Mitev
From: Nicolai Hähnle v2: * Add a gl_shader_spirv_data member to gl_shader, which already encapsulates a gl_spirv_module where the binary will be saved. (Eduardo Lima) * Just use the 'spirv_data' member to know whether a gl_shader has the SPIR_V_BINARY_ARB state. (Timothy Arceri)