Re: [Mesa-dev] [PATCH v2 04/13] nir: Use writemasked store_vars in glsl_to_nir.

2015-12-12 Thread Jason Ekstrand
I had some very minor comments but, with those addressed 1-4 are Reviewed-by: Jason Ekstrand On Dec 11, 2015 1:24 PM, "Kenneth Graunke" wrote: > Instead of performing the read-modify-write cycle in glsl->nir, we can > simply emit a partial writemask. For locals, nir_lower_vars_to_ssa will > do

[Mesa-dev] [PATCH v2 04/13] nir: Use writemasked store_vars in glsl_to_nir.

2015-12-11 Thread Kenneth Graunke
Instead of performing the read-modify-write cycle in glsl->nir, we can simply emit a partial writemask. For locals, nir_lower_vars_to_ssa will do the equivalent read-modify-write cycle for us, so we continue to get the same SSA values we had before. Because glsl_to_nir calls nir_lower_outputs_to_