Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

2017-06-08 Thread Samuel Pitoiset
On 06/08/2017 09:42 AM, Nicolai Hähnle wrote: There's another problem related to the hash tables: You need to call _mesa_hash_table_set_deleted_key(ht, NULL) to avoid a possible bug when a handle happens to be equal to the address of the default deleted key marker. I suggest adding a hash_t

Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

2017-06-08 Thread Samuel Pitoiset
On 06/07/2017 05:58 PM, Nicolai Hähnle wrote: On 30.05.2017 22:35, Samuel Pitoiset wrote: v2: - s/GLboolean/bool for HandleAllocated - fix _mesa_has_ARB_shader_image_load_store() checks - use u_vector for texture/image handles - fix use of 64-bit handles on 32-bit systems -

Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

2017-06-08 Thread Nicolai Hähnle
There's another problem related to the hash tables: You need to call _mesa_hash_table_set_deleted_key(ht, NULL) to avoid a possible bug when a handle happens to be equal to the address of the default deleted key marker. I suggest adding a hash_table_create wrapper analogous to the other wrapp

Re: [Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

2017-06-07 Thread Nicolai Hähnle
On 30.05.2017 22:35, Samuel Pitoiset wrote: v2: - s/GLboolean/bool for HandleAllocated - fix _mesa_has_ARB_shader_image_load_store() checks - use u_vector for texture/image handles - fix use of 64-bit handles on 32-bit systems - some cleanups Signed-off-by: Samuel Pitoiset -

[Mesa-dev] [PATCH v2 03/64] mesa: implement ARB_bindless_texture

2017-05-30 Thread Samuel Pitoiset
v2: - s/GLboolean/bool for HandleAllocated - fix _mesa_has_ARB_shader_image_load_store() checks - use u_vector for texture/image handles - fix use of 64-bit handles on 32-bit systems - some cleanups Signed-off-by: Samuel Pitoiset --- src/mesa/main/context.c | 3 + src/m